dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Dec 2022
11:01 am

Steve Jarpe <sjarpe@diality.com>

DEN-14316-chemical-disinfect. Changes for code review

Options
    • -35
    • +40
    ./ModeChemicalDisinfect.c
    • -25
    • +24
    ./ModeChemicalDisinfectFlush.c
    • -1
    • +17
    ./ModeChemicalDisinfectFlush.h
  4. … 1 more file in changeset.
10:36 am

Dara Navaei

DEN-14307 updated the concentrate pumps park command

Options
    • -32
    • +24
    ./ModeHeatDisinfect.c
  2. … 1 more file in changeset.
10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Sean Nash

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of co...

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of code unless there is a good reason (e.g. a dependency in assignment on code above).

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:59 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

DEN-14316: Replaced tabs with 4 spaces per code review.

Options
    • -32
    • +32
    ./ModeChemicalDisinfectFlush.c
9:52 am

Sean Nash

Align "="s.

Align "="s.

9:51 am

Sean Nash

Alignment - why is "=" pushed out so far?

Alignment - why is "=" pushed out so far?

9:46 am

Sean Nash

Align "="s.

Align "="s.

9:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:43 am

Sean Nash

I searched this file for tabs and replaced them with 4 spaces. Please check your editor tab settings. RESOLVED in CODE WALKTHROUGH.

I searched this file for tabs and replaced them with 4 spaces. Please check your editor tab settings.
RESOLVED in CODE WALKTHROUGH.

9:42 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

DEN-14316: Replaced tabs with 4 spaces per code review.

Options
    • -31
    • +31
    ./ModeChemicalDisinfect.c
7:14 am

Steve Jarpe

To be clear, does this mean all of the local declarations should be at the beginning of the function?

To be clear, does this mean all of the local declarations should be at the beginning of the function?

6:27 am

Steve Jarpe

I can't see this in Code Composer Studio.

I can't see this in Code Composer Studio.

6:26 am

Steve Jarpe

I can't see this in Code Composer Studio.

I can't see this in Code Composer Studio.

Monday 19 Dec 2022
4:45 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

4:44 pm

Sean Nash

Align.

Align.

4:44 pm

Sean Nash

Check indents.

Check indents.

4:44 pm

Sean Nash

Prefer local var declarations to be at top of scope where they're used.

Prefer local var declarations to be at top of scope where they're used.

4:43 pm

Sean Nash

Add blank line between declaration and code.

Add blank line between declaration and code.

4:42 pm

Sean Nash

Remove blank line.

Remove blank line.

4:42 pm

Sean Nash

Remove blank line.

Remove blank line.