dgfirmware / firmware / App / Services

Reservoirs.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 May 2025
8:59 am

Sean Nash

I don't see the flag being set in this function.

I don't see the flag being set in this function.

8:55 am

Sean Nash

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

8:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 20 May 2025
1:39 pm

Dara Navaei

Done

Done

1:38 pm

Dara Navaei

Done

Done

1:01 pm

Sean Nash

Should you do something with the received max ratio? It's local, so it's just being dropped.

Should you do something with the received max ratio? It's local, so it's just being dropped.

10:59 am

Sean Nash

max ratio

max ratio

Friday 16 May 2025
2:41 pm

Dara Navaei

DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
Friday 15 Nov 2024
12:53 pm

Dara Navaei

Monday 11 Mar 2024
10:14 am

Dara Navaei

10:13 am

Vinayakam Mani and Sean Nash

10:07 am

Dara Navaei

Friday 08 Mar 2024
4:40 pm

Michael Garthwaite

Thursday 07 Mar 2024
10:42 am

Dara Navaei

DG-DEN-16682_Use Cd2 Values For Acid Check
DG-DEN-16682_Use Cd2 Values For Acid Check
9:59 am

Dara Navaei

9:55 am

Vinayakam Mani and Michael Garthwaite

9:48 am

Dara Navaei

9:48 am

Dara Navaei

Wednesday 06 Mar 2024
2:48 pm

Sean Nash

Saturday 02 Mar 2024
6:38 pm

Dara Navaei

Friday 01 Mar 2024
4:16 pm

Dara Navaei

DG-DEN-16682_Use Cd2 Values For Acid Check
DG-DEN-16682_Use Cd2 Values For Acid Check
Friday 16 Feb 2024
10:59 am

Dara Navaei

10:59 am

Dara Navaei and Sean Nash

10:58 am

Dara Navaei

10:57 am

Dara Navaei

Thursday 15 Feb 2024
12:52 pm

Sean Nash

12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

Sean Nash

Question was in relation to DG gen idle sub-state, not HD mode.

Question was in relation to DG gen idle sub-state, not HD mode.

9:53 am

Darren Cox

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Tre...

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Treatment only.

9:28 am

Sean Nash

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen id...

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen idle states).