Reservoirs.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I don't see the flag being set in this function.

I don't see the flag being set in this function.

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

Should you do something with the received max ratio? It's local, so it's just being dropped.

Should you do something with the received max ratio? It's local, so it's just being dropped.

max ratio

max ratio

DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
DG-DEN-16682_Use Cd2 Values For Acid Check
DG-DEN-16682_Use Cd2 Values For Acid Check
DG-DEN-16682_Use Cd2 Values For Acid Check
DG-DEN-16682_Use Cd2 Values For Acid Check
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Question was in relation to DG gen idle sub-state, not HD mode.

Question was in relation to DG gen idle sub-state, not HD mode.

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Tre...

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Treatment only.

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen id...

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen idle states).