SystemComm.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-13801-sw_dev-sprint-79_mg' into develop

  1. … 12 more files in changeset.
RESOLVED IN CODE WALKTRHOUGH

RESOLVED IN CODE WALKTRHOUGH

Use 0.0F

Use 0.0F

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

Header needs to be updated

Header needs to be updated

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 14 more files in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Merged DEN-13834

  1. … 10 more files in changeset.
DEN-13834 updated the heaters driver

  1. … 3 more files in changeset.
Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

This code is un-commented.

This code is un-commented.

Done.

Done.

In in DEN-13834.

In in DEN-13834.

Done.

Done.

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

Done.

Done.

Done.

Done.

Align on "*" maybe?

Align on "*" maybe?

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.