dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Sep 2022
3:09 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598: Add code for RAM error and FPGA clcok speed.

Options
    • -14
    • +0
    ./Controllers/Heaters.h
    • -10
    • +0
    ./Controllers/LoadCell.h
    • -7
    • +0
    ./Controllers/TemperatureSensors.c
    • -29
    • +0
    ./Controllers/TemperatureSensors.h
    • -30
    • +0
    ./Services/AlarmMgmt.c
    • -1
    • +0
    ./Services/AlarmMgmt.h
    • -4
    • +15
    ./Services/FPGA.c
    • -0
    • +6
    ./Services/SystemComm.c
11:08 am

Sean Nash

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 t...

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 typed variable so it will be typed properly. A #define may or may not be typed depending on how it's used. If it's used in a mathematical expression, the compiler will make it max precision (double) if we don't explicitly add the 'F' suffix and that can cause some problems with the precision in the math.

10:31 am

Sean Nash

Remove blank line.

Remove blank line.

Thursday 15 Sep 2022
9:52 am

Dong Nguyen <dnguyen@diality.com>

DEN-13598 updated the code

Options
    • -15
    • +0
    ./Controllers/Heaters.h
    • -11
    • +0
    ./Controllers/LoadCell.h
    • -6
    • +0
    ./Controllers/TemperatureSensors.c
    • -30
    • +0
    ./Controllers/TemperatureSensors.h
    • -30
    • +0
    ./Services/AlarmMgmt.c
    • -1
    • +0
    ./Services/AlarmMgmt.h
    • -2
    • +2
    ./Services/FPGA.c
Wednesday 14 Sep 2022
8:36 pm

Dara Navaei

DEN-13834 updated the getValveState function to return the state of the valve in enum. Updated the treatment blocking data to be written to NV data. Updated the FlowSensors driver and renamed the dialysate flow messages to flow sensors messages

Options
    • -16
    • +15
    ./Controllers/FlowSensors.c
    • -7
    • +14
    ./Controllers/Heaters.c
    • -3
    • +3
    ./Controllers/ROPump.c
    • -13
    • +48
    ./Controllers/Valves.c
    • -28
    • +27
    ./Controllers/Valves.h
    • -2
    • +0
    ./DGCommon.h
    • -25
    • +57
    ./Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    ./Modes/ModeFault.c
    • -2
    • +0
    ./Modes/ModeFill.c
    • -31
    • +59
    ./Modes/ModeHeatDisinfect.c
    • -74
    • +0
    ./Modes/ModeStandby.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -27
    • +21
    ./Services/Reservoirs.c
    • -5
    • +6
    ./Services/SystemComm.c
    • -25
    • +60
    ./Services/SystemCommMessages.c
    • -6
    • +6
    ./Services/SystemCommMessages.h
5:08 pm

Sean Nash

DEN-13598: Updates to FPGA clock speed check.

Options
    • -1
    • +10
    ./Services/FPGA.c
    • -0
    • +1
    ./Services/FPGA.h
    • -1
    • +2
    ./Tasks/TaskGeneral.c
4:41 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13768 Feature complete changes to CoolDownHeater and CoolDownROFilter to imporve cool down time.

Options
    • -33
    • +88
    ./Modes/ModeHeatDisinfect.c
Tuesday 13 Sep 2022
12:36 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13768 DEN-13892 Start helper functions

Options
    • -2
    • +144
    ./Modes/ModeHeatDisinfect.c
Monday 12 Sep 2022
6:01 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13768 DEN-13892 Correct logic in getHeatDisinfectStatus.

Options
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
5:51 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13768 DEN-13892 Correct logic in getHeatDisinfectStatus.

Options
    • -1
    • +17
    ./Modes/ModeHeatDisinfect.c
4:24 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:24 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:23 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:23 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:04 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:03 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:46 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:46 pm

Michael Garthwaite

Merge branch 'DEN-13801-sw_dev-sprint-79_mg' into develop

Options
    • -2
    • +2
    ./Controllers/Heaters.c
    • -7
    • +7
    ./Controllers/LoadCell.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.h
    • -2
    • +2
    ./Modes/ModeService.c
    • -2
    • +2
    ./Modes/ModeStandby.c
    • -4
    • +4
    ./Modes/OperationModes.c
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/Reservoirs.c
    • -2
    • +2
    ./Services/Reservoirs.h
    • -2
    • +2
    ./Services/SystemComm.c
    • -4
    • +7
    ./Services/SystemCommMessages.c
    • -3
    • +3
    ./Services/SystemCommMessages.h
3:38 pm

Michael Garthwaite

DEN-13801: Updated testopmode doc string to reflect updated inputs/outputs.

Options
    • -2
    • +2
    ./Modes/OperationModes.c
3:34 pm

Michael Garthwaite

3:34 pm

wbracken  (deleted user)

3:32 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTRHOUGH

RESOLVED IN CODE WALKTRHOUGH

12:21 pm

Darren Cox

Use 0.0F

Use 0.0F

12:17 pm

Darren Cox

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

Sunday 11 Sep 2022
2:07 pm

Dara Navaei

DEN-13460 added PiSquare VectorCAST

Options
    • -12
    • +0
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Modes/ModeStandby.c
Friday 09 Sep 2022
1:56 pm

Michael Garthwaite

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

1:52 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598 updated the code

Options
    • -1
    • +1
    ./Tasks/TaskGeneral.c
10:04 am

wbracken  (deleted user)

Header needs to be updated

Header needs to be updated

Thursday 08 Sep 2022
5:21 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598 updated the code with the RAM alarms

Options
    • -12
    • +0
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -0
    • +28
    ./Services/FPGA.c
    • -2
    • +2
    ./Tasks/TaskGeneral.c
    • -0
    • +3
    ./Tasks/TaskPriority.c
5:13 pm

Michael Garthwaite