dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 May 2021
5:10 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
10:55 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -1
    • +2
    ./App/Modes/ModeDrain.c
    • -2
    • +2
    ./App/Services/Reservoirs.c
10:54 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
10:53 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -1
    • +2
    ./App/Modes/ModeDrain.c
    • -2
    • +2
    ./App/Services/Reservoirs.c
9:35 am

Sean Nash

Fixed.

Fixed.

9:06 am

Sean Nash

Yes. Fixed.

Yes. Fixed.

9:03 am

qnguyen  (deleted user)

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

Consider re-word to something more general. This function might be used by ModeHeatDisinfect to tare on an active reservoir.

8:58 am

qnguyen  (deleted user)

Should this be in interval count?

Should this be in interval count?

Tuesday 25 May 2021
9:56 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Updated temperature sensor alarms

Options
    • -3
    • +3
    ./App/Controllers/TemperatureSensors.c
4:14 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added persistence to concentrate pumps check

Options
    • -3
    • +3
    ./App/Controllers/TemperatureSensors.c
    • -8
    • +28
    ./App/Modes/ModeFill.c
1:12 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
1:12 pm

Sean Nash

Fixed merge conflicts.

Options
    • -7
    • +7
    ./App/Controllers/ROPump.c
    • -3
    • +3
    ./App/Controllers/TemperatureSensors.c
    • -5
    • +45
    ./App/Modes/ModeDrain.c
    • -7
    • +33
    ./App/Services/Reservoirs.c
    • -3
    • +5
    ./App/Services/Reservoirs.h
    • -4
    • +8
    ./App/Services/SystemComm.c
    • -0
    • +106
    ./App/Services/SystemCommMessages.c
    • -0
    • +9
    ./App/Services/SystemCommMessages.h
12:59 pm

Sean Nash

DEN-7605: Added support for UI clock sync.

Options
    • -4
    • +7
    ./App/Services/SystemComm.c
    • -0
    • +45
    ./App/Services/SystemCommMessages.c
    • -0
    • +3
    ./App/Services/SystemCommMessages.h
Monday 24 May 2021
11:24 pm

Sean Nash

DEN-7605: Fixed merge conflicts.

Options
    • -3
    • +3
    ./App/Controllers/TemperatureSensors.c
11:20 pm

Sean Nash

DEN-7605: Added POST messaging.

Options
    • -7
    • +15
    ./App/Modes/ModeInitPOST.c
    • -0
    • +61
    ./App/Services/SystemCommMessages.c
    • -0
    • +6
    ./App/Services/SystemCommMessages.h
3:00 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added safety check to fill using flow meter

Options
    • -5
    • +16
    ./App/Modes/ModeFill.c
    • -1
    • +0
    ./App/Services/Reservoirs.c
    • -0
    • +2
    ./App/Services/Reservoirs.h
10:09 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Enable water quality checks

Options
    • -1
    • +1
    ./App/DGCommon.h
    • -0
    • +2
    ./App/Modes/ModeStandby.c
Friday 21 May 2021
2:35 pm

Sean Nash

DEN-7605: Added tare state to drain mode to allow time for reservoir to settle first.

Options
    • -5
    • +45
    ./App/Modes/ModeDrain.c
    • -7
    • +33
    ./App/Services/Reservoirs.c
    • -1
    • +3
    ./App/Services/Reservoirs.h
10:42 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:21 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -7
    • +7
    ./App/Controllers/ROPump.c
10:20 am

Sean Nash

Fixed.

Fixed.

10:20 am

Sean Nash

Fixed.

Fixed.

9:18 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -2
    • +2
    ./App/DGCommon.h
9:18 am

Sean Nash

Fixed merge conflicts.

Options
    • -0
    • +4
    ./.launches/DG.launch
    • -4
    • +109
    ./App/Controllers/DrainPump.c
    • -2
    • +69
    ./App/Controllers/ROPump.c
    • -8
    • +69
    ./App/Controllers/Valves.c
    • -0
    • +1
    ./App/Controllers/Valves.h
    • -2
    • +2
    ./App/DGCommon.h
    • -6
    • +10
    ./App/Modes/ModeDrain.c
    • -1
    • +4
    ./App/Modes/ModeHeatDisinfect.c
    • -1
    • +0
    ./App/Modes/ModeStandby.c
8:54 am

Sean Nash

DEN-7605: Added delays to drain mode.

Options
    • -0
    • +12
    ./App/Controllers/DrainPump.c
    • -1
    • +1
    ./App/Controllers/DrainPump.h
    • -4
    • +10
    ./App/Modes/ModeDrain.c
Thursday 20 May 2021
12:18 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Imposed maximum crc size

Options
    • -101
    • +2
    ./App/Services/AlarmMgmt.h
    • -0
    • +130
    ./App/Services/AlarmMgmtSWFaults.h
    • -2
    • +14
    ./App/Services/FPGA.c
    • -0
    • +2
    ./App/Services/FPGA.h
    • -25
    • +54
    ./App/Services/Integrity.c
11:26 am

qnguyen  (deleted user)

The only preference is to put TRUE first if it is == such as below.

The only preference is to put TRUE first if it is == such as below.

8:58 am

Sean Nash

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

Wednesday 19 May 2021
6:33 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
5:15 pm

Sean Nash

Should we move this enum to separate .h file?

Should we move this enum to separate .h file?