firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DEN-14778_FW Drain Current Alarm Not Activating AT Correct Level When Pump IS Off
DG-DEN-14778_FW Drain Current Alarm Not Activating AT Correct Level When Pump IS Off
DG-DEN-15199_FW DN Sprint
DG-DEN-15199_FW DN Sprint
Corrected.

Corrected.

Align "="

Align "="

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Please check the code again.

Please check the code again.

Done

Done

Done

Done

Done

Done

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

Done

Done

request will remain if inlet alarms active. is that what we want?

request will remain if inlet alarms active. is that what we want?

Yes we do not support Beta in release.

Yes we do not support Beta in release.

Looks like we will not read ADC channels at all if release build.

Looks like we will not read ADC channels at all if release build.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Needs default or just do if/else.

Needs default or just do if/else.

Needs default or just do if/else.

Needs default or just do if/else.

Yes, fault.

Yes, fault.