dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Jul 2020
8:14 pm

Dara Navaei

DEN-3421 merged with other branches

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
11:59 am

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Addressed code reviews and removed VC previous import errors

Options
    • -25
    • +32
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +2
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -3
    • +1
    /firmware/App/Modes/ModeFill.c
    • -3
    • +3
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -968
    • +377
    /results/VectorCAST.log
    • -1
    • +1
    /results/cppcheckError.csv
11:42 am

Sean Nash

Use notifications for RTI interrupt handling like HD.

Options
    • -7
    • +42
    /firmware/App/Services/Interrupts.c
    • -3
    • +0
    /firmware/source/rti.c
11:38 am

Dara Navaei

Merge branch 'DEN-2490-firmware-lockup' into DEN-3421-dg-heat-disinfection

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -5
    • +5
    /firmware/App/Services/PIControllers.c
    • -144
    • +187
    /firmware/App/Services/SystemComm.c
    • -67
    • +85
    /firmware/App/Services/SystemCommMessages.c
    • -5
    • +3
    /firmware/App/Services/SystemCommMessages.h
11:37 am

Dara Navaei

Resolved a merge conflict with master

Options
    • -17
    • +18
    /firmware/App/Controllers/DrainPump.c
    • -15
    • +16
    /firmware/App/Controllers/DrainPump.h
    • -19
    • +22
    /firmware/App/Controllers/ROPump.c
    • -15
    • +16
    /firmware/App/Controllers/ROPump.h
    • -15
    • +16
    /firmware/App/Controllers/TemperatureSensors.c
    • -14
    • +19
    /firmware/App/Modes/ModeDrain.c
    • -15
    • +16
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -15
    • +16
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -15
    • +16
    /firmware/App/Services/PIControllers.c
    • -15
    • +16
    /firmware/App/Services/PIControllers.h
    • -17
    • +16
    /firmware/App/Services/SystemComm.c
    • -19
    • +20
    /firmware/App/Services/SystemCommMessages.c
    • -15
    • +16
    /firmware/App/Services/SystemCommMessages.h
9:18 am

Sean Nash

Fix module headers.

Options
    • -1
    • +1
    /firmware/App/Services/Interrupts.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.h
Monday 20 Jul 2020
5:53 pm

Sean Nash

Handle CAN and UART error/warning notifications. Differentiated HD from DG s/w fault. Updated some older module/function headers to latest format.

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +3
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -3
    • +3
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +2
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +32
    /firmware/App/Modes/ModeSolo.c
    • -4
    • +6
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -2
    • +2
    /firmware/App/Services/AlarmMgmt.c
  16. … 13 more files in changeset.
1:59 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Fixed doxygen errors and corrected spelling errors

Options
    • -6
    • +8
    /firmware/App/Controllers/ConductivitySensors.c
    • -5
    • +7
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +1
    /results/Build_Status_Report.csv
    • -347
    • +592
    /results/VectorCAST.log
1:33 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Fixed constant name and FPGA control address

Options
    • -4
    • +4
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Services/FPGA.c
9:26 am

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Added unit tests and integration test

Options
    • -1
    • +2
    /results/Build_Status_Report.csv
    • -604
    • +2260
    /results/VectorCAST.log
    • -44
    • +46
    /results/cppcheck.log
    • -36
    • +37
    /results/cppcheckError.csv
Friday 17 Jul 2020
4:33 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Check inlet water conductivity during Fill, Drain, and Recirculate Modes

Options
    • -21
    • +116
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +5
    /firmware/App/Modes/ModeDrain.c
    • -0
    • +5
    /firmware/App/Modes/ModeFill.c
    • -0
    • +4
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +9
    /firmware/App/Services/SystemComm.c
    • -1
    • +27
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +7
    /firmware/App/Services/SystemCommMessages.h
4:09 pm

Sean Nash

Fixed bug where new debug event for full buffer would overflow a temporary buffer to hold the event text. Removed some obsolete comm buffer protection code. Removed obsolete CAN test build option.

Options
    • -4
    • +3
    /firmware/App/DGCommon.h
    • -6
    • +0
    /firmware/App/Modes/OperationModes.c
    • -28
    • +23
    /firmware/App/Services/CommBuffers.c
    • -0
    • +1
    /firmware/App/Services/CommBuffers.h
    • -6
    • +2
    /firmware/App/Services/SystemComm.c
    • -27
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -5
    • +0
    /firmware/App/Services/SystemCommMessages.h
    • -21
    • +0
    /firmware/App/Tasks/TaskGeneral.c
    • -2
    • +0
    /firmware/App/Tasks/TaskPriority.c
    • -1
    • +1
    /firmware/DG.dil
    • -2
    • +2
    /firmware/source/sys_startup.c
10:39 am

Sean Nash

Added CAN channel for DG to send to UI. Added task/interrup timing measurement test code. Added debug code for CAN/UART error interrupts and alarm trigger/clear events. Added new f/w debug messaging support. Added FPGA version info to versions message.

Options
    • -1
    • +1
    /firmware/.launches/DG.launch
    • -2
    • +3
    /firmware/App/DGCommon.h
    • -5
    • +13
    /firmware/App/Services/AlarmMgmt.c
    • -8
    • +6
    /firmware/App/Services/CommBuffers.c
    • -1
    • +2
    /firmware/App/Services/CommBuffers.h
    • -16
    • +19
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
    • -20
    • +20
    /firmware/App/Services/Interrupts.c
    • -3
    • +4
    /firmware/App/Services/SystemComm.c
    • -40
    • +84
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
    • -2
    • +14
    /firmware/App/Tasks/TaskGeneral.c
    • -3
    • +15
    /firmware/App/Tasks/TaskPriority.c
    • -2
    • +5
    /firmware/App/Tasks/TaskTimer.c
    • -7
    • +7
    /firmware/DG.dil
    • -0
    • +19
    /firmware/source/can.c
Thursday 16 Jul 2020
11:08 am

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Refactor and add outlet conductivity sensor

Options
    • -0
    • +2
    /firmware/App/Controllers/ConductivitySensors.h
    • -0
    • +59
    /firmware/App/Services/FPGA.c
    • -0
    • +5
    /firmware/App/Services/FPGA.h
    • -0
    • +45
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +4
    /firmware/App/Services/SystemCommMessages.h
    • -0
    • +2
    /firmware/source/sys_main.c
Monday 13 Jul 2020
5:07 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Add conductivity sensor module for inlet water

Options
    • -0
    • +260
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +57
    /firmware/App/Controllers/ConductivitySensors.h
    • -5
    • +38
    /firmware/App/Services/FPGA.c
    • -0
    • +3
    /firmware/App/Services/FPGA.h
    • -2
    • +6
    /firmware/App/Tasks/TaskPriority.c
Thursday 09 Jul 2020
8:29 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -2
    • +2
    /firmware/App/DGCommon.h
Wednesday 08 Jul 2020
4:59 pm

Dara Navaei

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -15
    • +16
    /firmware/App/Controllers/DrainPump.c
    • -15
    • +16
    /firmware/App/Controllers/DrainPump.h
    • -15
    • +16
    /firmware/App/Controllers/Heaters.c
    • -15
    • +16
    /firmware/App/Controllers/Heaters.h
    • -15
    • +16
    /firmware/App/Controllers/LoadCell.c
    • -15
    • +16
    /firmware/App/Controllers/LoadCell.h
    • -15
    • +16
    /firmware/App/Controllers/Pressures.c
    • -15
    • +16
    /firmware/App/Controllers/Pressures.h
    • -15
    • +16
    /firmware/App/Controllers/ROPump.c
    • -15
    • +16
    /firmware/App/Controllers/ROPump.h
    • -15
    • +16
    /firmware/App/Controllers/TemperatureSensors.c
    • -15
    • +16
    /firmware/App/Controllers/TemperatureSensors.h
    • -15
    • +16
    /firmware/App/Controllers/Valves.c
    • -15
    • +16
    /firmware/App/Controllers/Valves.h
    • -9
    • +10
    /firmware/App/DGCommon.h
  16. … 60 more files in changeset.
4:51 pm

Dara Navaei

Ran the test script after merge with DEN-2650

Options
    • -4
    • +3
    /results/Build_Status_Report.csv
    • -2332
    • +1819
    /results/VectorCAST.log
4:12 pm

Dara Navaei

DEN-2650 Fixed merge conflict with master

Options
2:56 pm

Sean Nash

Fixed initial broadcast intervals for RO and Drain pumps.

Options
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -3
    • +14
    /results/Build_Status_Report.csv
    • -243
    • +293
    /results/VectorCAST.log
12:32 pm

Sean Nash

Complete IT for Valves module.

Options
    • -0
    • +1
    /results/.gitignore
    • -0
    • +74
    /results/Build_Status_Report.csv
    • -0
    • +15717
    /results/VectorCAST.log
    • -0
    • +147
    /results/cppcheck.log
    • -0
    • +86
    /results/cppcheckError.csv
Monday 06 Jul 2020
6:58 pm

Sean Nash

UT and IT updates. Added IT for Reservoirs.c.

Options
    • -5
    • +8
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Modes/ModeRecirculate.c
8:19 am

Dara Navaei

DEN-3421 modified RO pump and Drain pump and added a control loop to them.

Options
    • -5
    • +24
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.h
    • -2
    • +2
    /firmware/App/Controllers/ROPump.h
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -2
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -0
    • +2
    /firmware/App/Services/PIControllers.c
    • -1
    • +2
    /firmware/App/Services/PIControllers.h
Thursday 02 Jul 2020
5:27 pm

Sean Nash

Fix reservoir mix-up in Drain/Fill modes. Added test code to turn fan on when starting re-circ mode to cool heater until fan module is written.

Options
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
    • -0
    • +9
    /firmware/App/Modes/ModeRecirculate.c
Monday 29 Jun 2020
1:59 pm

Sean Nash

IT updates.

Options
    • -2
    • +4
    /firmware/App/Services/SystemCommMessages.c
Friday 26 Jun 2020
3:23 pm

Sean Nash

UT updates. Added UT for Reservoirs module. Minor fixes per UT.

Options
    • -0
    • +4
    /firmware/App/Modes/ModeDrain.c
    • -0
    • +7
    /firmware/App/Services/Reservoirs.c
9:26 am

Dara Navaei

Merge branch 'DEN-2650-dg-firmware-infrastructure' into DEN-3421-dg-heat-disinfection

Options
    • -4
    • +45
    /firmware/App/Controllers/ROPump.c
    • -4
    • +3
    /firmware/App/Controllers/TemperatureSensors.c
    • -7
    • +7
    /firmware/App/Services/SystemCommMessages.c
8:59 am

Dara Navaei

DEN-3421 work in progress. Added a state to ramp up the RO pump for the targeted flow

Options
    • -10
    • +138
    /firmware/App/Controllers/ROPump.c
    • -6
    • +15
    /firmware/App/Controllers/ROPump.h
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +15
    /firmware/App/Controllers/UVReactors.c
    • -5
    • +19
    /firmware/App/Controllers/UVReactors.h
    • -127
    • +116
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +4
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -0
    • +1
    /firmware/App/Services/PIControllers.h
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -1
    • +40
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +4
    /firmware/App/Services/SystemCommMessages.h
Thursday 25 Jun 2020
4:46 pm

Sean Nash

UT updates. Updated RO pump PI coefficients to make less aggressive based on lab testing.

Options
    • -1
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -1
    • +1
    /firmware/App/Controllers/LoadCell.h
    • -2
    • +1
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -0
    • +4
    /firmware/App/Modes/ModeFill.c
9:17 am

Sean Nash

Changed state of VRc from re-circ state to drain state in re-circulate mode per latest SA.

Options
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c