dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Jul 2020
2:12 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Added doxygen comment and rename variable

Options
    • -32
    • +33
    /firmware/App/Controllers/TemperatureSensors.c
1:53 pm

Dara Navaei

DEN-3421 Work in progress, added code to heat disinfect states

Options
    • -2
    • +0
    /firmware/App/Controllers/ROPump.c
    • -70
    • +232
    /firmware/App/Modes/ModeHeatDisinfect.c
12:20 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Refacor POST tests

Options
    • -6
    • +18
    /firmware/App/Controllers/TemperatureSensors.c
11:56 am

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Rename temperature sensors enumeration

Options
    • -2
    • +2
    /firmware/App/Controllers/ConductivitySensors.c
    • -12
    • +12
    /firmware/App/Controllers/Heaters.c
    • -55
    • +55
    /firmware/App/Controllers/TemperatureSensors.c
    • -13
    • +13
    /firmware/App/Controllers/TemperatureSensors.h
9:53 am

Quang Nguyen <qnguyen@diality.com>

DEN 4184: Added self test for pressure sensors

Options
    • -25
    • +72
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.h
    • -0
    • +6
    /firmware/App/Modes/ModeInitPOST.c
Tuesday 28 Jul 2020
2:59 pm

Dara Navaei

DEN-3421 modified the control logic of the RO pump. Updated SystemCommMessages with the new commands

Options
    • -35
    • +44
    /firmware/App/Controllers/ROPump.c
    • -5
    • +0
    /firmware/App/Services/FPGA.c
    • -3
    • +3
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
Monday 27 Jul 2020
9:08 pm

Dara Navaei

DEN-3421 added functions to DrainPump.c/h and ROPump.c/h to support open loop and closed loop control modes. Added the command functions for Dialin

Options
    • -48
    • +124
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +6
    /firmware/App/Controllers/DrainPump.h
    • -124
    • +117
    /firmware/App/Controllers/ROPump.c
    • -13
    • +6
    /firmware/App/Controllers/ROPump.h
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +9
    /firmware/App/Services/SystemComm.c
    • -8
    • +48
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +8
    /firmware/App/Services/SystemCommMessages.h
2:11 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Check inlet water temperature in Fill, Drain, and Re-circulate modes

Options
    • -28
    • +49
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.h
    • -0
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -0
    • +2
    /firmware/App/Modes/ModeFill.c
    • -0
    • +2
    /firmware/App/Modes/ModeRecirculate.c
Sunday 26 Jul 2020
5:22 pm

Dara Navaei

DEN-3421 added more functions to RO pump

Options
    • -20
    • +28
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.h
    • -60
    • +90
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.h
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -8
    • +8
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -6
    • +9
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
Friday 24 Jul 2020
5:29 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Restructure temperature sensor module

Options
    • -185
    • +140
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +8
    /firmware/App/Controllers/TemperatureSensors.h
2:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
2:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.h
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/OperationModes.c
  16. … 12 more files in changeset.
1:55 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-3922-dg-inlet-water-quality' into master

Options
1:55 pm

Sean Nash

Match HD arrangement for CAN Tx manager.

Options
    • -11
    • +7
    /firmware/App/Services/SystemComm.c
1:35 pm

Quang Nguyen <qnguyen@diality.com>

Added software fault id to support utility change

Options
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
Thursday 23 Jul 2020
7:20 pm

Sean Nash

Finish fix to Valves module. Allow transition to heat disinfect mode from standby mode. Fix CAN comm logic for when DG is alone on bus.

Options
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -1
    • +2
    /firmware/App/Services/AlarmMgmt.h
    • -4
    • +1
    /firmware/App/Services/CommBuffers.c
    • -0
    • +1
    /firmware/App/Services/CommBuffers.h
    • -1
    • +1
    /firmware/App/Services/Interrupts.c
    • -34
    • +47
    /firmware/App/Services/SystemComm.c
6:08 pm

Dara Navaei

DEN-3421 modified the RO pump module and added commands to run from SystemComm

Options
    • -0
    • +5
    /firmware/.launches/DG.launch
    • -13
    • +35
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +4
    /firmware/App/Controllers/DrainPump.h
    • -36
    • +51
    /firmware/App/Controllers/ROPump.c
    • -5
    • +5
    /firmware/App/Controllers/ROPump.h
    • -3
    • +3
    /firmware/App/DGCommon.h
    • -23
    • +84
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -1
    • +1
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/PIControllers.c
    • -1
    • +1
    /firmware/App/Services/PIControllers.h
    • -1099
    • +1059
    /firmware/App/Services/SystemComm.c
    • -47
    • +39
    /firmware/App/Services/SystemComm.h
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
9:32 am

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Added missing break in switch case

Options
    • -0
    • +1
    /firmware/App/Services/SystemComm.c
Wednesday 22 Jul 2020
6:51 pm

Sean Nash

Added range checks to several functions.

Options
    • -10
    • +14
    /firmware/App/Controllers/TemperatureSensors.c
    • -7
    • +14
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +0
    /firmware/App/Services/PIControllers.c
    • -4
    • +6
    /firmware/App/Services/SystemComm.c
5:47 pm

Sean Nash

Removed V1 build option. UT updates.

Options
    • -5
    • +4
    /firmware/App/DGCommon.h
    • -4
    • +0
    /firmware/App/Modes/ModeDrain.c
    • -4
    • +0
    /firmware/App/Modes/ModeFill.c
    • -37
    • +33
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/Interrupts.c
    • -16
    • +2
    /firmware/App/Services/Reservoirs.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
5:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Added doxygen comments

Options
    • -5
    • +5
    /firmware/App/Services/MsgQueues.c
    • -2
    • +1
    /firmware/App/Services/PIControllers.c
2:49 pm

Quang Nguyen <qnguyen@diality.com>

Clean up all import errors in vector cast

Options
    • -2
    • +1
    /results/Build_Status_Report.csv
    • -821
    • +606
    /results/VectorCAST.log
2:23 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Addressed code reviews

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +0
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +0
    /firmware/App/Services/AlarmMgmt.c
    • -3
    • +0
    /firmware/App/Services/MsgQueues.c
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -238
    • +238
    /results/VectorCAST.log
    • -0
    • +1
    /results/cppcheck.log
Tuesday 21 Jul 2020
8:56 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Addressed code reviews and removed VC previous import errors

Options
    • -12
    • +18
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +0
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +3
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -3
    • +3
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
  16. … 13 more files in changeset.
8:14 pm

Dara Navaei

DEN-3421 merged with other branches

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
11:59 am

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Addressed code reviews and removed VC previous import errors

Options
    • -25
    • +32
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +2
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -3
    • +1
    /firmware/App/Modes/ModeFill.c
    • -3
    • +3
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -968
    • +377
    /results/VectorCAST.log
    • -1
    • +1
    /results/cppcheckError.csv
11:42 am

Sean Nash

Use notifications for RTI interrupt handling like HD.

Options
    • -7
    • +42
    /firmware/App/Services/Interrupts.c
    • -3
    • +0
    /firmware/source/rti.c
11:38 am

Dara Navaei

Merge branch 'DEN-2490-firmware-lockup' into DEN-3421-dg-heat-disinfection

Options
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -5
    • +5
    /firmware/App/Services/PIControllers.c
    • -144
    • +187
    /firmware/App/Services/SystemComm.c
    • -67
    • +85
    /firmware/App/Services/SystemCommMessages.c
    • -5
    • +3
    /firmware/App/Services/SystemCommMessages.h
11:37 am

Dara Navaei

Resolved a merge conflict with master

Options
    • -17
    • +18
    /firmware/App/Controllers/DrainPump.c
    • -15
    • +16
    /firmware/App/Controllers/DrainPump.h
    • -19
    • +22
    /firmware/App/Controllers/ROPump.c
    • -15
    • +16
    /firmware/App/Controllers/ROPump.h
    • -15
    • +16
    /firmware/App/Controllers/TemperatureSensors.c
    • -14
    • +19
    /firmware/App/Modes/ModeDrain.c
    • -15
    • +16
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -15
    • +16
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -15
    • +16
    /firmware/App/Services/PIControllers.c
    • -15
    • +16
    /firmware/App/Services/PIControllers.h
    • -17
    • +16
    /firmware/App/Services/SystemComm.c
    • -19
    • +20
    /firmware/App/Services/SystemCommMessages.c
    • -15
    • +16
    /firmware/App/Services/SystemCommMessages.h
9:18 am

Sean Nash

Fix module headers.

Options
    • -1
    • +1
    /firmware/App/Services/Interrupts.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.h