Activity dialin/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	21
Last Commit:	19 Nov
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 12 Jul 2022

10:44 am

Michael Garthwaite

More
401bcac
changed 0 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-13427-sw_dev-sprint-75_mg'

Conflicts:

dialin/hd/pretreatment.py

10:02 am

Michael Garthwaite

More
945e735
changed 5 files
DEN-12358-sw_dev-sprint-67_mg DIALIN-DEN-12358-1

Merge branch 'staging' into DEN-12358-sw_dev-sprint-67_mg

- -13
- +16
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -4
- +4
/dialin/dg/chemical_disinfect.py
- History
- Source
- Diff
/dialin/dg/chemical_disinfect.py
- -2
- +2
/dialin/hd/alarms.py
- History
- Source
- Diff
/dialin/hd/alarms.py
- -5
- +38
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py
- -22
- +37
/dialin/ui/dg_simulator.py
- History
- Source
- Diff
/dialin/ui/dg_simulator.py

10:01 am

Michael Garthwaite

More
28b3b6d
changed 1 file
DEN-12358-sw_dev-sprint-67_mg DIALIN-DEN-12358-1

code review

- -1
- +1
/dialin/hd/alarms.py
- History
- Source
- Diff
/dialin/hd/alarms.py

9:58 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:51 am

Michael Garthwaite

In ticket http://dvm-linux02:8080/browse/DIAL-171

In ticket http://dvm-linux02:8080/browse/DIAL-171

9:00 am

Dara Navaei

More
e90810e
changed 0 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'develop' of ssh://dvm-linux02:7999/vv/dialin into develop

9:00 am

Dara Navaei

More
e67b967
changed 5 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

DEN-12931 updated the scripts for testing

- -2
- +2
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -4
- +9
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py
- -2
- +2
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py
- -2
- +2
/tests/peter/set_RTCs.py
- History
- Source
- Diff
/tests/peter/set_RTCs.py
- -2
- +2
/tests/peter/test_dg_records.py
- History
- Source
- Diff
/tests/peter/test_dg_records.py

Monday 11 Jul 2022

3:17 pm

Sean Nash

More
64a2533
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' into develop

- -0
- +11
/dialin/dg/events.py
- History
- Source
- Diff
/dialin/dg/events.py

3:17 pm

Sean Nash

More
07c40d6
changed 2 files
DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DIALIN-DEN-12931-1

DEN-12931: Added clear event list commands.

- -0
- +11
/dialin/dg/events.py
- History
- Source
- Diff
/dialin/dg/events.py
- -0
- +11
/dialin/hd/hd_events.py
- History
- Source
- Diff
/dialin/hd/hd_events.py

1:29 pm

Sean Nash

More
dcb7a19
changed 0 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' into develop

1:28 pm

Sean Nash

More
9790d4c
changed 2 files
DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DIALIN-DEN-12931-1

DEN-12931: Added DG reservoir tare command.

- -0
- +1
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -0
- +20
/dialin/dg/reservoirs.py
- History
- Source
- Diff
/dialin/dg/reservoirs.py

Friday 08 Jul 2022

6:01 pm

Sean Nash

More
c233924
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' into develop

- -0
- +45
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py

6:00 pm

Sean Nash

More
099d683
changed 2 files
DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DIALIN-DEN-12931-1

DEN-12931: Added DG service mode cmd.

- -0
- +1
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -0
- +45
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py

9:56 am

Michael Garthwaite

More
5f99b74
changed 3 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13427-sw_dev-sprint-75_mg and 176 more DIALIN-DEN-13427-1

Merge remote-tracking branch 'origin/DEN-12609-sw_dev-sprint-69_mg' into DEN-13427-sw_dev-sprint-75_mg

- -2
- +27
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -13
- +2
/dialin/hd/alarms.py
- History
- Source
- Diff
/dialin/hd/alarms.py
- -0
- +8
/dialin/hd/pretreatment.py
- History
- Source
- Diff
/dialin/hd/pretreatment.py

Thursday 07 Jul 2022

1:25 pm

Michael Garthwaite

More
Re: DIALIN-DEN-12716-1
commented on review

was MSG_ID_HD_ACCELEROMETER_DATA supposed to be removed as well?

was MSG_ID_HD_ACCELEROMETER_DATA supposed to be removed as well?

Wednesday 06 Jul 2022

11:05 am

Michael Garthwaite

More
Re: DIALIN-DEN-12716-1
commented on review

Please add data types of the parameters.

Please add data types of the parameters.

9:30 am

Sean Nash

Not sure a list is appropriate. And if list does make sense, should probably be a list of messages that do require ACK (as generally we do not want Dialin ACKing - we want Dialin to be passive and ...

Not sure a list is appropriate. And if list does make sense, should probably be a list of messages that do require ACK (as generally we do not want Dialin ACKing - we want Dialin to be passive and let HD/DG/UI do the ACKing). Let's discuss with Michael.

9:27 am

Sean Nash

RESOLVED.

RESOLVED.

9:26 am

Sean Nash

RESOLVED.

RESOLVED.

9:26 am

Sean Nash

RESOLVED.

RESOLVED.

9:26 am

Sean Nash

More
Re: DIALIN-DEN-12716-1
commented on review

What criteria is used to determine whether a message is included in this list?

What criteria is used to determine whether a message is included in this list?

Friday 01 Jul 2022

5:49 pm

Behrouz NematiPour

Wow, eagle-eye, duplicates removed.

Wow, eagle-eye,
duplicates removed.

5:49 pm

Behrouz NematiPour

duplicates removed.

duplicates removed.

5:49 pm

Behrouz NematiPour

Wow, eagle-eye, duplicates removed.

Wow, eagle-eye,
duplicates removed.

5:30 pm

Behrouz NematiPour

More
fb54198
changed 1 file
DEN-12716-UI_BN_S70, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DIALIN-DEN-12716-1

DIALIN-DEN-12716 : DIALIN-DEN-12716-1 : DIALIN-DEN-12716_UI BN S70

- Addressing code reviews.

- -5
- +0
/dialin/common/msg_defs.py
- History
- Source
- Diff
/dialin/common/msg_defs.py

4:26 pm

Behrouz NematiPour

Probably because assuming that the list of ACK_NOT_REQUIRED messages (at least at the time of implementation) was a shorter list.

Probably because assuming that the list of ACK_NOT_REQUIRED messages (at least at the time of implementation) was a shorter list.

3:42 pm

Michael Garthwaite

More
10821f7
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' into develop

- -1
- +1
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py

3:42 pm

Michael Garthwaite

More
975c47d
changed 1 file
DEN-12931-dg_hd_dev-hd_dg_dvt-update, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DIALIN-DEN-12931-1

DIAL-169: changed ui_proxy's request version from dialin - hd to ui broadcast to get the DG to reply

- -1
- +1
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py

10:45 am

Sean Nash

More
Re: DIALIN-DEN-12716-1
commented on review

Why are there 2 of these?

Why are there 2 of these?

10:45 am

Sean Nash

More
Re: DIALIN-DEN-12716-1
commented on review

Why are there 2 of these?

Why are there 2 of these?

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2025-12-29 02:37 -0800