fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-11114: Backed out alarm macro change to prevent compiler warnings.

DEN-11114 addressed the code review comments

Done.

Done.

Done.

Done.

No I do not think so. The CRCs are all checked in the self test.

No I do not think so. The CRCs are all checked in the self test.

Done.

Done.

Yes, if you add "alarm no alarm" it will not be checked.

Yes, if you add "alarm no alarm" it will not be checked.

Done.

Done.

Magic numbers on these new for loops.

Magic numbers on these new for loops.

Align comment.

Align comment.

DEN-11114 worked on NV data management

Done.

Done.

Fixed it.

Fixed it.

Done.

Done.

Done.

Done.

Done.

Done.

DEN-11114 fixed the blood leak calibration structure

Update message list with latest data details.

Update message list with latest data details.

Update message list with latest broadcast msg data details.

Update message list with latest broadcast msg data details.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buf...

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buffer to populate - otherwise it will overwrite memory.

.crc?

.crc?

1 and 0 is not clear. Better to say FIFO send and reset.

1 and 0 is not clear. Better to say FIFO send and reset.

Create and trigger new alarm.

Create and trigger new alarm.

.crc?

.crc?

Recommend changing > to >= and then removing the - 1.

Recommend changing > to >= and then removing the - 1.

Please update message list details for this broadcast msg.

Please update message list details for this broadcast msg.

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.