fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14307 moved the DG usage info record to common.h so HD can use it as well. Updated the DG usage info per the latest requirements

HD-DEN-14307_DG HD Dev HD DG Dvt Update Part 6
HD-DEN-14307_DG HD Dev HD DG Dvt Update Part 6
Merge branch 'DEN-14150-hd-dialysate-flow-estimation' into develop

Merge branch 'DEN-14175-dg_hd_dev-hd_dg_dvt-update-part-5' into develop

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

DEN-14175 moved the hardware configurations enum to the common from utilities

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14175 addressed a code review comment

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

DEN-14175 addressed a code review comment by removing the getHardwareConfig function

Done

Done

Done.

Done.

Done.

Done.

DEN-14175 removed a blank line

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

Doesn't this command take a pointer to a structure now?

Doesn't this command take a pointer to a structure now?

This is here so both stacks can use it.

This is here so both stacks can use it.

Done.

Done.

Why is this in utilities module? Doesn't it make more sense in fpga module?

Why is this in utilities module? Doesn't it make more sense in fpga module?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove blank line.

Remove blank line.

None of these structures appear to require packing - all 32-bit fields.

None of these structures appear to require packing - all 32-bit fields.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH