Activity fwcommon/

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:54 am

Michael Garthwaite

More
Re: DG-DEN-14999-2
commented on review

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

7:04 pm

Sean Nash

More
Re: DG-DEN-14646-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

7:03 pm

Dara Navaei

More
e9ffda0
changed 1 file
develop

Merge branch 'DEN-14999-alarm-table-updates' into develop

- -2
- +144
/NVDataMgmt.c
- History
- Source
- Diff
/NVDataMgmt.c

3:43 pm

Dara Navaei

More
90de168
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 81 more DG-DEN-14999-2

DEN-14999, DEN-15031 reused the start DG structure that already exists

- -8
- +2
/Common.h
- History
- Source
- Diff
/Common.h

2:30 pm

Dara Navaei

More
76839e8
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 81 more DG-DEN-14999-2

DEN-14999, DEN-15031 updated the DG NV records with the acid and bicarb values

- -0
- +7
/NVDataMgmtDGRecords.h
- History
- Source
- Diff
/NVDataMgmtDGRecords.h

1:33 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
af6827e
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14646-fpga-alarm-properties-and-timing-3 and 82 more DG-DEN-14646-1

DEN-14646 Code cleanup

- -1
- +1
/PersistentAlarm.c
- History
- Source
- Diff
/PersistentAlarm.c

11:36 am

Dara Navaei

More
7ed3b20
changed 2 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 81 more DG-DEN-14999-2

DEN-14999, DEN-15031 updated the NV data management to add the fill conductivity values.

- -1
- +141
/NVDataMgmt.c
- History
- Source
- Diff
/NVDataMgmt.c
- -1
- +34
/NVDataMgmtDGRecords.h
- History
- Source
- Diff
/NVDataMgmtDGRecords.h

11:35 am

Sean Nash

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

4:44 pm

Dara Navaei

More
9192f93
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 81 more DG-DEN-14999-2

DEN-14999 added another condition in NV data management to make sure all the jobs in the queue are processed and the state machine is in idle state so even the last queue has been fully read