fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 Sep 2023
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
8:56 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Wednesday 27 Sep 2023
4:40 pm

jtaylor  (deleted user)

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

1:07 pm

Sean Nash

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

8:30 am

jtaylor  (deleted user)

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

Tuesday 19 Sep 2023
4:18 pm

wbracken  (deleted user)

2:34 pm

Michael Garthwaite and Darren Cox

2:07 pm

Dara Navaei

DG-DEN-16446_DG Dev Test Clean UP
DG-DEN-16446_DG Dev Test Clean UP
10:05 am

Dara Navaei

HD-STT-2938_Alarm Alarm ID HD Set Rtc Year Invalid 86 IS Not Generated When I Send Invalid Date Time
HD-STT-2938_Alarm Alarm ID HD Set Rtc Year Invalid 86 IS Not Generated When I Send Invalid Date Time
Thursday 14 Sep 2023
3:15 pm

Michael Garthwaite

3:13 pm

wbracken  (deleted user) and jtaylor  (deleted user)

10:05 am

Dara Navaei

HD-STT-3027_Vtchd 455 Rtc Battery Low Override Fires TO Early
HD-STT-3027_Vtchd 455 Rtc Battery Low Override Fires TO Early
Friday 08 Sep 2023
10:29 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Thursday 07 Sep 2023
1:50 pm

Sean Nash

Done.

Done.

1:15 pm

jtaylor  (deleted user)

Align declaration comments as a block on the right.

Align declaration comments as a block on the right.

8:37 am

wbracken  (deleted user)

Tuesday 05 Sep 2023
2:23 pm

Vinayakam Mani

10:13 am

jtaylor  (deleted user)

Friday 01 Sep 2023
5:05 pm

Vinayakam Mani

12:33 pm

Sean Nash

Thursday 31 Aug 2023
11:03 am

wbracken  (deleted user)

Wednesday 30 Aug 2023
2:25 pm

Michael Garthwaite

2:25 pm

wbracken  (deleted user) and jtaylor  (deleted user)

12:06 pm

Dara Navaei

HD-DEN-16325_Alarm 137 HD Excessive Tilt Alarm AT Power UP
HD-DEN-16325_Alarm 137 HD Excessive Tilt Alarm AT Power UP
Tuesday 29 Aug 2023
5:01 pm

Dara Navaei

2:07 pm

Dara Navaei

HD-DEN-15792_HD Software Design Description
HD-DEN-15792_HD Software Design Description