hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7091: Added fault for each self-test check

    • -9
    • +20
    /firmware/App/Controllers/BloodFlow.c
    • -10
    • +21
    /firmware/App/Controllers/DialInFlow.c
    • -12
    • +8
    /firmware/App/Controllers/PresOccl.c
    • -0
    • +1
    /firmware/App/Modes/ConsumableSelfTest.c
Either add TODO or delete commented line.

Either add TODO or delete commented line.

Not better to use this instead? bloodPumpMotorEdgeCount += (U16)(delta);

Not better to use this instead? bloodPumpMotorEdgeCount += (U16)(delta);

Removed. It seems nothing much we can do. The door switch is simple and just a GPIO read from FPGA.

Removed. It seems nothing much we can do. The door switch is simple and just a GPIO read from FPGA.

Straw door needs to be open for concentrate jugs' connection. Other than that, I am not aware of any flow path that requires closed door. Added TODO.

Straw door needs to be open for concentrate jugs' connection. Other than that, I am not aware of any flow path that requires closed door.
Added TODO.

Done.

Done.

Combined air trap and bubble detectors into one used cartridge check.

Combined air trap and bubble detectors into one used cartridge check.

Combined air trap and bubble detectors into one used cartridge check.

Combined air trap and bubble detectors into one used cartridge check.

DEN-7091: Addressed code review

Wrong valve state. Fixed.

Wrong valve state. Fixed.

Fixed.

Fixed.

Fixed. Now the BP pump should be off when the test is done.

Fixed. Now the BP pump should be off when the test is done.

The valves were not correct. It should be back to the previous state when the BP is off. The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP. Added 2 se...

The valves were not correct. It should be back to the previous state when the BP is off.
The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP.
Added 2 seconds time out for pressure to be normalized.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement. Removed the check for settle time in second displacement setup.

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement.
Removed the check for settle time in second displacement setup.

Probably should be fabs() here. And change 1 to 1.0.

Probably should be fabs() here. And change 1 to 1.0.

Probably should be fabs() here. and change 1 to 1.0.

Probably should be fabs() here. and change 1 to 1.0.

Why fabs() here?

Why fabs() here?

Should set settleStartTime here.

Should set settleStartTime here.

Pressure should be float. Add .0 to end of value.

Pressure should be float. Add .0 to end of value.

These volumes (4 of them) should be floats so we should add .0 to end of set value.

These volumes (4 of them) should be floats so we should add .0 to end of set value.

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.