hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
8:37 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added fault for each self-test check

Options
    • -9
    • +20
    /firmware/App/Controllers/BloodFlow.c
    • -10
    • +21
    /firmware/App/Controllers/DialInFlow.c
    • -12
    • +8
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.h
    • -0
    • +1
    /firmware/App/Modes/ConsumableSelfTest.c
    • -30
    • +12
    /firmware/App/Modes/SelfTests.c
5:30 pm

pmontazemi  (deleted user)

Either add TODO or delete commented line.

Either add TODO or delete commented line.

5:24 pm

pmontazemi  (deleted user)

Not better to use this instead? bloodPumpMotorEdgeCount += (U16)(delta);

Not better to use this instead? bloodPumpMotorEdgeCount += (U16)(delta);

4:44 pm

qnguyen  (deleted user)

Removed. It seems nothing much we can do. The door switch is simple and just a GPIO read from FPGA.

Removed. It seems nothing much we can do. The door switch is simple and just a GPIO read from FPGA.

4:43 pm

qnguyen  (deleted user)

Straw door needs to be open for concentrate jugs' connection. Other than that, I am not aware of any flow path that requires closed door. Added TODO.

Straw door needs to be open for concentrate jugs' connection. Other than that, I am not aware of any flow path that requires closed door.
Added TODO.

4:41 pm

qnguyen  (deleted user)

Done.

Done.

4:41 pm

qnguyen  (deleted user)

Combined air trap and bubble detectors into one used cartridge check.

Combined air trap and bubble detectors into one used cartridge check.

4:41 pm

qnguyen  (deleted user)

Combined air trap and bubble detectors into one used cartridge check.

Combined air trap and bubble detectors into one used cartridge check.

4:40 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Addressed code review

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -4
    • +13
    /firmware/App/Modes/SampleWater.c
    • -1
    • +1
    /firmware/App/Modes/SampleWater.h
    • -97
    • +86
    /firmware/App/Modes/SelfTests.c
3:44 pm

qnguyen  (deleted user)

Wrong valve state. Fixed.

Wrong valve state. Fixed.

3:44 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:44 pm

qnguyen  (deleted user)

Fixed. Now the BP pump should be off when the test is done.

Fixed. Now the BP pump should be off when the test is done.

3:43 pm

qnguyen  (deleted user)

The valves were not correct. It should be back to the previous state when the BP is off. The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP. Added 2 se...

The valves were not correct. It should be back to the previous state when the BP is off.
The pressure should be back with in 5 mmHg with the first pressure measurements before we run BP.
Added 2 seconds time out for pressure to be normalized.

3:41 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:36 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:36 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:35 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:35 pm

Sean Nash

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

Then I would rename the function/state to something less bubble detector and more used cartridge check 2.

3:35 pm

Sean Nash

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

Then I would rename the function/state to something less bubble detector and more used cartridge check 1.

3:35 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:34 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:32 pm

qnguyen  (deleted user)

Fixed.

Fixed.

3:32 pm

qnguyen  (deleted user)

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement. Removed the check for settle time in second displacement setup.

The reservoir should be settled for the first verify already. There is no need to wait for another settle to start second displacement.
Removed the check for settle time in second displacement setup.

3:31 pm

Sean Nash

Probably should be fabs() here. And change 1 to 1.0.

Probably should be fabs() here. And change 1 to 1.0.

3:31 pm

Sean Nash

Probably should be fabs() here. and change 1 to 1.0.

Probably should be fabs() here. and change 1 to 1.0.

3:30 pm

Sean Nash

Why fabs() here?

Why fabs() here?

3:23 pm

Sean Nash

Should set settleStartTime here.

Should set settleStartTime here.

3:21 pm

Sean Nash

Pressure should be float. Add .0 to end of value.

Pressure should be float. Add .0 to end of value.

3:20 pm

Sean Nash

These volumes (4 of them) should be floats so we should add .0 to end of set value.

These volumes (4 of them) should be floats so we should add .0 to end of set value.

3:18 pm

Sean Nash

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.

Why using fabs() here? Reservoir 1 should have gone down and reservoir 2 should have gone up. If opposite happened, we should not pass the test.