hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Apr 2021
11:14 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Updated temperature sensor publish data structure

Options
    • -17
    • +24
    /firmware/App/Controllers/DGInterface.h
10:56 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code review

Options
    • -3
    • +3
    /firmware/App/Controllers/SyringePump.c
10:42 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code review

Options
    • -2
    • +2
    /firmware/App/Modes/ModePostTreat.c
10:41 am

qnguyen  (deleted user)

Done.

Done.

10:39 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code review

Options
    • -0
    • +2
    /firmware/App/Modes/ModePostTreat.c
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +2
    /firmware/App/Services/AlarmMgmt.h
10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

Only reverse when using == operator

Only reverse when using == operator

10:36 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:19 am

Dara Navaei

That is what I meant. Why are we even passing this when we know the target is 0?

That is what I meant. Why are we even passing this when we know the target is 0?

Sunday 25 Apr 2021
10:32 pm

qnguyen  (deleted user)

Added.

Added.

10:32 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code reviews

Options
    • -34
    • +34
    /firmware/App/Controllers/DGInterface.h
    • -17
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -3
    • +3
    /firmware/App/Controllers/SyringePump.c
    • -6
    • +24
    /firmware/App/Modes/ModePostTreat.c
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
10:22 pm

qnguyen  (deleted user)

Changed to return none.

Changed to return none.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:17 pm

qnguyen  (deleted user)

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

10:14 pm

qnguyen  (deleted user)

Added.

Added.

10:12 pm

qnguyen  (deleted user)

I think the variable will be used in future to detect incorrect direction. Sean Nash Please elaborate more.

I think the variable will be used in future to detect incorrect direction.
Sean Nash Please elaborate more.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:09 pm

qnguyen  (deleted user)

The function has been removed.

The function has been removed.