Activity hdfirmware/

3:04 pm

Dara Navaei

More
9d55bf1
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750 addressed the code review comments

- -6
- +7
/firmware/App/Controllers/Fans.c
- History
- Source
- Diff
/firmware/App/Controllers/Fans.c

2:27 pm

Dara Navaei

More
fcb9a1d
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750 addressed the code review comments

- -1
- +1
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -4
- +2
/firmware/App/Controllers/Fans.c
- History
- Source
- Diff
/firmware/App/Controllers/Fans.c
- -2
- +0
/firmware/App/Controllers/Fans.h
- History
- Source
- Diff
/firmware/App/Controllers/Fans.h
- -3
- +5
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c

2:05 pm

Dara Navaei

More
Re: HD-DEN-11750-2
replied to Sean Nash

Done.

1:59 pm

Dara Navaei

More
Re: HD-DEN-11750-2
replied to Sean Nash

Yes, I have a TODO to finish them off in DEN-12224.

1:54 pm

Dara Navaei

More
Re: HD-DEN-11750-2
replied to Sean Nash

Done.

1:52 pm

Dara Navaei

More
Re: HD-DEN-11750-2
replied to Sean Nash

Done.

1:51 pm

Dara Navaei

More
Re: HD-DEN-11750-2
replied to Sean Nash

Yes, I tried a release build and it compiled.

1:46 pm

Dara Navaei

More
Re: HD-DEN-11750-2
replied to Sean Nash

Done.

11:53 am

Hung Nguyen <hnguyen@diality.com>

More
1bb1704
changed 1 file
DEN-11250-hd-syringe-pump-updates HD-DEN-11250-1

DEN-11250 Added code to allow resume after syringe pump occlusion has been removed

- -3
- +7
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

11:47 am

Hung Nguyen <hnguyen@diality.com>

More
e9c3c03
changed 1 file
demo_branch, develop and 2 more

DEN-11250 Added code to allow resume after the syringe pump occlusion has been removed

- -3
- +7
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

11:47 am

Dara Navaei

More
03c8b76
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

11:39 am

Sean Nash

More
Re: HD-DEN-11750-2
commented on review

Magic #.

11:38 am

Sean Nash

More
Re: HD-DEN-11750-2
commented on review

Seems we are not consistent about using #ifndef RELEASE. We have it here, but not in the if above on line 400.

Seems we are not consistent about using #ifndef RELEASE. We have it here, but not in the if above on line 400.

11:32 am

Sean Nash

More
Re: HD-DEN-11750-2
commented on review

I think we should use <> for library includes. And they should go on top.

11:29 am

Sean Nash

More
Re: HD-DEN-11750-2
commented on review

Remove blank line. And what is new remove field for?

11:19 am

Sean Nash

More
Re: HD-DEN-11750-2
commented on review

Have you tried a release build to see if we have this right?

11:14 am

Sean Nash

They do not. Remove volatile from these declarations.

11:08 am

Sean Nash

More
Re: HD-DEN-11750-2
commented on review

Fix indenting here.

8:14 pm

Dara Navaei

More
HD-DEN-12121-1
started review

HD-DEN-12121_SW Dev Sprint 65

5:25 pm

Dara Navaei

More
3e2f4f9
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

5:25 pm

Dara Navaei

More
0616cee
changed 1 file
demo_branch, develop and 2 more

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

5:24 pm

Dara Navaei

More
7ba72af
changed 1 file
demo_branch, develop and 2 more

Enabled a build switch

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

4:27 pm

Dara Navaei

More
405d46b
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750 resolved a merge conflict

- -20
- +0
/firmware/App/Controllers/AirTrap.c
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.c

2:28 pm

Dara Navaei

More
28643ed
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750 merged cc-vectorcast2 and resolved the conflcits

- -33
- +53
/firmware/App/Controllers/AirTrap.c
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.c

2:20 pm

Dara Navaei

More
f0c6971
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-UCOMMITS-20

Committed the lastest VectorCAST changes in cc-vectorcast2

- -49
- +50
/firmware/App/Controllers/AirTrap.c
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.c

4:19 pm

Hung Nguyen <hnguyen@diality.com>

More
2693297
changed 2 files
DEN-11250-hd-syringe-pump-updates HD-DEN-11250-1

DEN-11250 Fixed syringe pump occlusion alarm not triggered

- -4
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -1
- +1
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

4:08 pm

Dara Navaei

More
5a7cf73
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

4:08 pm

Hung Nguyen <hnguyen@diality.com>

More
eb60ac3
changed 2 files
demo_branch, develop and 2 more

DEN-11250 Fixed syringe pump occlusion alarm not triggered

- -4
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -2
- +2
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

3:00 pm

Darren Cox <darren_m@cox.net>

More
8ba9bec
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 334 more HD-UCOMMITS-19

DEN-10974 Added check of Door and Pump Track for states after installation.

- -16
- +21
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c

12:07 pm

Darren Cox <darren_m@cox.net>

More
596b965
changed 5 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 334 more HD-DEN-12215-2

Removed obsolete function getFPGADoorState(). Use getFPGAFrontDoorStatus() or getSwitchStatus() for debounced value.

- -2
- +2
/firmware/App/Modes/ModePostTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePostTreat.c
- -4
- +4
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -2
- +2
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -15
- +0
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -2
- +0
/firmware/App/Services/FPGA.h
- History
- Source
- Diff
/firmware/App/Services/FPGA.h

hdfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Hung Nguyen <hnguyen@diality.com>

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Darren Cox <darren_m@cox.net>

Darren Cox <darren_m@cox.net>