hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 18 Jan 2023
11:55 am

Darren Cox

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

11:53 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:50 am

Sean Nash

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

11:48 am

Sean Nash

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

11:15 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:13 am

Darren Cox

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

11:08 am

Darren Cox

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Tuesday 17 Jan 2023
2:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:57 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:56 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:25 pm

Darren Cox

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

1:04 pm

Sean Nash

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

12:13 pm

Darren Cox

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

11:35 am

Sean Nash

Done.

Done.

11:32 am

Sean Nash

Done.

Done.

11:32 am

Sean Nash

Done.

Done.

11:01 am

Dara Navaei

HD-DEN-14328_HD Event Issues
HD-DEN-14328_HD Event Issues
9:57 am

wbracken  (deleted user)

Add pressureSelfTestNormalizedStartTime to header.

Add pressureSelfTestNormalizedStartTime to header.

9:55 am

wbracken  (deleted user)

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

9:54 am

wbracken  (deleted user)

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

9:44 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Monday 16 Jan 2023
3:01 pm

Dara Navaei

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
Friday 13 Jan 2023
1:58 pm

Darren Cox

1:17 pm

Dara Navaei

8:46 am

Sean Nash

It is in the header under Outputs.

It is in the header under Outputs.

Thursday 12 Jan 2023
5:25 pm

Sean Nash

5:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:09 pm

wbracken  (deleted user)

Add dgServiceAndUsageData to header.

Add dgServiceAndUsageData to header.

3:28 pm

Darren Cox

Agree. Done.

Agree. Done.

3:12 pm

Sean Nash

Should we have an else for this if where we zero the positionOUtOfRangeCounter?

Should we have an else for this if where we zero the positionOUtOfRangeCounter?