hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing...

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

Done.

Done.

Done.

Done.

Done.

Done.

HD-DEN-14328_HD Event Issues
HD-DEN-14328_HD Event Issues
Add pressureSelfTestNormalizedStartTime to header.

Add pressureSelfTestNormalizedStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

Add pressureSelfTestPreNormalStartTime to header.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
It is in the header under Outputs.

It is in the header under Outputs.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Add dgServiceAndUsageData to header.

Add dgServiceAndUsageData to header.

Agree. Done.

Agree. Done.

Should we have an else for this if where we zero the positionOUtOfRangeCounter?

Should we have an else for this if where we zero the positionOUtOfRangeCounter?