hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

Was expecting you to move if, not else. Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Was expecting you to move if, not else.
Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Thank you - corrected.

Thank you - corrected.

Why accept Heparin resume when our syringe is empty?

Why accept Heparin resume when our syringe is empty?

It looks like we could get here pretty regularly while we're waiting for command transmit to complete (if statement above) which should not be counted as a comm error unless it's taking too long (t...

It looks like we could get here pretty regularly while we're waiting for command transmit to complete (if statement above) which should not be counted as a comm error unless it's taking too long (timeout).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

HD-DEN-15183_IN Treatment Rinseback Workflow Changes
HD-DEN-15183_IN Treatment Rinseback Workflow Changes
HD-DEN-15203_Alarm Does Not Trigger When Blood Pump IS Reversed
HD-DEN-15203_Alarm Does Not Trigger When Blood Pump IS Reversed
Alarm checks re-ordered.

Alarm checks re-ordered.

Comment corrected.

Comment corrected.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

Not needed. Remove.

Not needed. Remove.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Fixed.

Fixed.

Fixed.

Fixed.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done.

Done.