hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 Apr 2023
4:03 pm

wbracken  (deleted user) , jtaylor  (deleted user) and Dara Navaei

3:20 pm

jtaylor  (deleted user)

Done.

Done.

1:55 pm

Sean Nash

Was expecting you to move if, not else. Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Was expecting you to move if, not else.
Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

12:25 pm

jtaylor  (deleted user)

Thank you - corrected.

Thank you - corrected.

10:43 am

Michael Garthwaite

10:31 am

Sean Nash

Why accept Heparin resume when our syringe is empty?

Why accept Heparin resume when our syringe is empty?

10:23 am

Sean Nash

It looks like we could get here pretty regularly while we're waiting for command transmit to complete (if statement above) which should not be counted as a comm error unless it's taking too long (t...

It looks like we could get here pretty regularly while we're waiting for command transmit to complete (if statement above) which should not be counted as a comm error unless it's taking too long (timeout).

10:06 am

Sean Nash

9:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

Friday 21 Apr 2023
8:01 pm

Dara Navaei

HD-DEN-15183_IN Treatment Rinseback Workflow Changes
HD-DEN-15183_IN Treatment Rinseback Workflow Changes
4:01 pm

Dara Navaei

HD-DEN-15203_Alarm Does Not Trigger When Blood Pump IS Reversed
HD-DEN-15203_Alarm Does Not Trigger When Blood Pump IS Reversed
3:03 pm

jtaylor  (deleted user)

Alarm checks re-ordered.

Alarm checks re-ordered.

3:01 pm

jtaylor  (deleted user)

Comment corrected.

Comment corrected.

2:06 pm

Sean Nash

1:51 pm

Dara Navaei

1:42 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:41 pm

Sean Nash

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

1:31 pm

Sean Nash

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

12:15 pm

Darren Cox

12:15 pm

jtaylor  (deleted user)

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

11:42 am

Sean Nash

Not needed. Remove.

Not needed. Remove.

11:15 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:14 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:06 am

Sean Nash

Fixed.

Fixed.

11:04 am

Sean Nash

Fixed.

Fixed.

10:23 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:18 am

jtaylor  (deleted user)

Done.

Done.

Thursday 20 Apr 2023
2:46 pm

wbracken  (deleted user)