Activity hdfirmware/firmware/App/Controllers/DGInterface.c

11:27 am

Dara Navaei

More
cb83129
changed 3 files
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 257 more HD-DEN-14763-1

Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

- -22
- +29
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
… 2 more files in changeset.

11:37 am

Sean Nash

More
Re: HD-DEN-14830-2
commented on review

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm. And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm. D...

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm.
And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm.
Did Systems want to separate these? My understanding was not to separate.

10:25 am

Michael Garthwaite

More
0b0c511
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more HD-DEN-14830-2

DEN-14830: reworked dialysate temp timeouts and conditions. Restored previous persistence alarms. added below 33 degC alarm

- -36
- +22
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c

8:46 am

Michael Garthwaite

More
23c460c
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 250 more HD-DEN-14830-2

Merge branch 'staging' into DEN-14830-incorrect-dialysate-temperature-alarm-triggered

- -22
- +29
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c

4:04 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

This will hard fault the HD. Please change to getTreatmentParameterU32()

4:04 pm

Michael Garthwaite

More
Re: HD-DEN-13154-1
commented on review

This will hard fault the HD. Please change to getTreatmentParameterU32()

10:01 am

Michael Garthwaite

More
ba78a6c
changed 6 files
develop

Merge branch 'DEN-14689-messaging-bugs' into develop

- -1
- +1
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
… 5 more files in changeset.

11:40 am

Sean Nash

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide ...

Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide what properties/persistence should be set.

11:37 am

Michael Garthwaite

More
Re: HD-DEN-14830-2
replied to Sean Nash

PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD 901) does. which one should be enforced?

11:30 am

Sean Nash

More
Re: HD-DEN-14830-2
commented on review

I thought the non-safety temp alarms had a large persistence. Now they have none?

11:27 am

Sean Nash

More
Re: HD-DEN-14830-2
commented on review

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

10:10 am