hdfirmware / firmware / App / Controllers

DGInterface.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Nov 2023
10:19 am

Vinayakam Mani

DEN-16391 code review comments fix

Options
    • -1
    • +1
    ./DGInterface.h
  2. … 1 more file in changeset.
9:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:32 am

Sean Nash

First letter (c) should be lower case.

First letter (c) should be lower case.

9:29 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:28 am

Sean Nash

Would dgCurrentActiveReservoir be a better name? I assume Temp refers to temperature (not temporary), but purpose is still not clear.

Would dgCurrentActiveReservoir be a better name? I assume Temp refers to temperature (not temporary), but purpose is still not clear.

Monday 27 Nov 2023
11:08 am

Vinayakam Mani

Done.

Done.

11:08 am

Vinayakam Mani

Done.

Done.

11:08 am

Vinayakam Mani

Done.

Done.

11:08 am

Vinayakam Mani

Done.

Done.

11:08 am

Vinayakam Mani

Done.

Done.

11:08 am

Vinayakam Mani

Done.

Done.

11:08 am

Vinayakam Mani

Done.

Done.

11:08 am

Vinayakam Mani

Done.

Done.

11:07 am

Vinayakam Mani

Done.

Done.

11:07 am

Vinayakam Mani

Done.

Done.

11:07 am

Vinayakam Mani

Done.

Done.

11:01 am

Vinayakam Mani

DEN-16391 TDi temp review commentsfix

Options
    • -0
    • +2
    ./DGInterface.h
  2. … 1 more file in changeset.
9:14 am

Sean Nash

Any reason why these reservoir variables are not part of the DG_TDI_TEMP_COUNTER_T structure?

Any reason why these reservoir variables are not part of the DG_TDI_TEMP_COUNTER_T structure?

9:13 am

Sean Nash

Remove blank line.

Remove blank line.

9:13 am

Sean Nash

Space after if.

Space after if.

9:12 am

Sean Nash

Space after if.

Space after if.

9:12 am

Sean Nash

Space after if.

Space after if.

9:11 am

Sean Nash

Space after if.

Space after if.