DialInFlow.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14007, DEN-14099 Merge & fix conflicts.

  1. … 3 more files in changeset.
Merge branch 'DEN-14344-sw-s85-mg-air-pump' into develop

  1. … 9 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 20 more files in changeset.
DEN-14307: partial fix to DEN-14086.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

Done

Done

Data is a local variable but added alarmButtonBlockers

Data is a local variable but added alarmButtonBlockers

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

data and alarmButtonBlockers?

data and alarmButtonBlockers?

Should alarmButtonBlockers and ALARM_TABLE also be added.

Should alarmButtonBlockers and ALARM_TABLE also be added.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

I think we still want to keep the comment. It has not been implemented yet.

I think we still want to keep the comment. It has not been implemented yet.

Done

Done

Done

Done

Done

Done

Fixed the setServiceTime function. Thanks.

Fixed the setServiceTime function. Thanks.

Done.

Done.

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Moved to Init.

Moved to Init.