hdfirmware / firmware / App / Controllers

DialInFlow.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Apr
3:01 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./DialInFlow.c
  2. … 19 more files in changeset.
2:57 pm

Dara Navaei

1:56 pm

Michael Garthwaite and Sean Nash

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:47 pm

Dara Navaei

Done

Done

12:37 pm

Sean Nash

Bad practice to have two calls to same function here. Possible that 2nd call will return different result. Should call function once to assign value to a local var prior to if statement and then re...

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.

12:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

Dara Navaei

Yes. I think we should have these events to information.

Yes. I think we should have these events to information.

Thursday 03 Apr
9:00 am

Sean Nash

Are these permanent?

Are these permanent?

Tuesday 01 Apr
8:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 31 Mar
9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 28 Mar
1:17 pm

Sean Nash

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

1:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:15 pm

Dara Navaei

Moved it to OperationModes

Moved it to OperationModes

11:00 am

Sean Nash

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we foll...

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

10:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 26 Mar
5:52 pm

Dara Navaei

Done

Done

9:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:21 am

Sean Nash

2 blank lines above/below test banner.

2 blank lines above/below test banner.

Tuesday 25 Mar
9:41 am

Dara Navaei

Done

Done

9:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:37 am

Sean Nash

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

9:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 21 Mar
10:33 am

Sean Nash

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

8:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:44 am

Sean Nash

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

8:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 20 Mar
2:19 pm

Dara Navaei

Done

Done

2:17 pm

Dara Navaei

Done

Done