PresOccl.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while...

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while VBT is open.

Indent 2nd and 3rd line of if by 2 more spaces.

Indent 2nd and 3rd line of if by 2 more spaces.

Capitalize Level and Ctr. Add doxygen comment.

Capitalize Level and Ctr. Add doxygen comment.

Should be a group ending /*@}/ at bottom here.

Should be a group ending /*@}/ at bottom here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I think we want one more blank line (should be 2 total) before TEST SUPPORT banner.

I think we want one more blank line (should be 2 total) before TEST SUPPORT banner.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Keep blank line between declaration and code and between code and return statement.

Keep blank line between declaration and code and between code and return statement.

Keep a blank line before return statement.

Keep a blank line before return statement.

Keep blank line between declaration and return statement.

Keep blank line between declaration and return statement.

How does the getAirPumpMotorState() give a T/F for alarm detection?

How does the getAirPumpMotorState() give a T/F for alarm detection?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I think you're stuck with what you last commanded. You might try the get to see if it works, but I think those only work for input pins. RESOLVED in CODE WALKTHROUGH.

I think you're stuck with what you last commanded. You might try the get to see if it works, but I think those only work for input pins.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Need function header.

Need function header.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.