hdfirmware / firmware / App / Controllers

PresOccl.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 19 Dec 2022
6:08 pm

Sean Nash

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

6:01 pm

Sean Nash

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

6:00 pm

Sean Nash

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

5:58 pm

Sean Nash

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

5:57 pm

Sean Nash

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while...

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while VBT is open.

5:43 pm

Sean Nash

Indent 2nd and 3rd line of if by 2 more spaces.

Indent 2nd and 3rd line of if by 2 more spaces.

5:43 pm

Sean Nash

Capitalize Level and Ctr. Add doxygen comment.

Capitalize Level and Ctr. Add doxygen comment.

5:42 pm

Sean Nash

Should be a group ending /*@}/ at bottom here.

Should be a group ending /*@}/ at bottom here.

5:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:38 pm

Sean Nash

I think we want one more blank line (should be 2 total) before TEST SUPPORT banner.

I think we want one more blank line (should be 2 total) before TEST SUPPORT banner.

5:37 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:34 pm

Sean Nash

Keep blank line between declaration and code and between code and return statement.

Keep blank line between declaration and code and between code and return statement.

5:33 pm

Sean Nash

Keep a blank line before return statement.

Keep a blank line before return statement.

5:30 pm

Sean Nash

Keep blank line between declaration and return statement.

Keep blank line between declaration and return statement.

5:29 pm

Sean Nash

How does the getAirPumpMotorState() give a T/F for alarm detection?

How does the getAirPumpMotorState() give a T/F for alarm detection?

5:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:27 pm

Sean Nash

I think you're stuck with what you last commanded. You might try the get to see if it works, but I think those only work for input pins. RESOLVED in CODE WALKTHROUGH.

I think you're stuck with what you last commanded. You might try the get to see if it works, but I think those only work for input pins.
RESOLVED in CODE WALKTHROUGH.

5:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:23 pm

Sean Nash

Need function header.

Need function header.

5:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.