hdfirmware / firmware / App / Controllers

PresOccl.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 May 2023
1:37 pm

Dara Navaei

11:21 am

wbracken  (deleted user) and Sean Nash

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Dara Navaei

Done

Done

9:38 am

Dara Navaei

Done

Done

8:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:21 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 08 May 2023
3:58 pm

Dara Navaei

This was updated but not pushed.

This was updated but not pushed.

3:55 pm

Dara Navaei

This was a mistake. I fixed it.

This was a mistake. I fixed it.

9:30 am

Dara Navaei

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
9:26 am

Dara Navaei

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
9:22 am

Dara Navaei

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
9:06 am

Sean Nash

Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

9:03 am

Sean Nash

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

9:02 am

Sean Nash

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

8:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:52 am

Sean Nash

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 04 May 2023
10:39 am

Dara Navaei

Please see changes.

Please see changes.

10:35 am

Dara Navaei

Done

Done

Tuesday 02 May 2023
5:06 pm

Sean Nash

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

4:52 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

Thursday 27 Apr 2023
10:02 am

Dara Navaei

HD-DEN-15199_FW DN Sprint 95 Part 2
HD-DEN-15199_FW DN Sprint 95 Part 2
Friday 21 Apr 2023
2:06 pm

Sean Nash

1:51 pm

Dara Navaei

11:15 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:14 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:06 am

Sean Nash

Fixed.

Fixed.

11:04 am

Sean Nash

Fixed.

Fixed.