PresOccl.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove blank line.

Remove blank line.

Use enums instead of literals.

Use enums instead of literals.

Don't we have an enum for these values?

Don't we have an enum for these values?

Is there more to be done here (TODO)?

Is there more to be done here (TODO)?

I think these variable declarations should stay here. Why move to function?

I think these variable declarations should stay here. Why move to function?

This is HD f/w. Why are you looking at DG mode?

This is HD f/w. Why are you looking at DG mode?

Why aren't these declared at top of file and initialized in init function like everything else.

Why aren't these declared at top of file and initialized in init function like everything else.

Why is this in two places? And why set every 10ms when it appears to be constant?

Why is this in two places? And why set every 10ms when it appears to be constant?

This doesn't seem to ever change. Why not just initialize this value once on reset?

This doesn't seem to ever change. Why not just initialize this value once on reset?

Make U32.

Make U32.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This was updated but not pushed.

This was updated but not pushed.

This was a mistake. I fixed it.

This was a mistake. I fixed it.

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Please see changes.

Please see changes.