hdfirmware / firmware / App / Controllers

PresOccl.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 May 2023
11:02 am

Sean Nash

Remove blank line.

Remove blank line.

11:01 am

Sean Nash

Use enums instead of literals.

Use enums instead of literals.

11:01 am

Sean Nash

Don't we have an enum for these values?

Don't we have an enum for these values?

10:58 am

Sean Nash

Is there more to be done here (TODO)?

Is there more to be done here (TODO)?

10:56 am

Sean Nash

I think these variable declarations should stay here. Why move to function?

I think these variable declarations should stay here. Why move to function?

10:55 am

Sean Nash

This is HD f/w. Why are you looking at DG mode?

This is HD f/w. Why are you looking at DG mode?

10:53 am

Sean Nash

Why aren't these declared at top of file and initialized in init function like everything else.

Why aren't these declared at top of file and initialized in init function like everything else.

10:35 am

Sean Nash

Why is this in two places? And why set every 10ms when it appears to be constant?

Why is this in two places? And why set every 10ms when it appears to be constant?

10:34 am

Sean Nash

This doesn't seem to ever change. Why not just initialize this value once on reset?

This doesn't seem to ever change. Why not just initialize this value once on reset?

10:33 am

Sean Nash

Make U32.

Make U32.

Tuesday 09 May 2023
1:37 pm

Dara Navaei

11:21 am

wbracken  (deleted user) and Sean Nash

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Dara Navaei

Done

Done

9:38 am

Dara Navaei

Done

Done

8:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:21 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 08 May 2023
3:58 pm

Dara Navaei

This was updated but not pushed.

This was updated but not pushed.

3:55 pm

Dara Navaei

This was a mistake. I fixed it.

This was a mistake. I fixed it.

9:30 am

Dara Navaei

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
9:26 am

Dara Navaei

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
9:22 am

Dara Navaei

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
9:06 am

Sean Nash

Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

9:03 am

Sean Nash

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

9:02 am

Sean Nash

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

8:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:52 am

Sean Nash

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 04 May 2023
10:39 am

Dara Navaei

Please see changes.

Please see changes.