hdfirmware / firmware / App / Controllers

PresOccl.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Aug 2023
3:00 pm

Darren Cox

Updated spelling and as Input here.

Updated spelling and as Input here.

2:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Sean Nash

This is an odd description of useShort parameter.

This is an odd description of useShort parameter.

2:17 pm

Sean Nash

useShortStablizeTime is an input, not output (and is mis-spelled).

useShortStablizeTime is an input, not output (and is mis-spelled).

2:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:59 am

Darren Cox

Fixed

Fixed

10:49 am

Darren Cox

Done

Done

10:49 am

Darren Cox

Done

Done

10:48 am

Darren Cox

Updated

Updated

10:48 am

Darren Cox

signalInitiatePressureStabilization() call and periodic re-stabilize will go to PRESSURE_LIMITS_STATE_STABILIZATION. When coming from this state (PRESSURE_LIMITS_STATE_WIDE), stabilization should a...

signalInitiatePressureStabilization() call and periodic re-stabilize will go to PRESSURE_LIMITS_STATE_STABILIZATION. When coming from this state (PRESSURE_LIMITS_STATE_WIDE), stabilization should always be the Normal length, not the Short length.

10:44 am

Darren Cox

Updated header, removed parameter to use static var instead. Good catch.

Updated header, removed parameter to use static var instead. Good catch.

10:42 am

Darren Cox

Updated header.

Updated header.

Tuesday 22 Aug 2023
1:02 pm

Sean Nash

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

1:01 pm

Sean Nash

Provide parameter name in prototype.

Provide parameter name in prototype.

1:00 pm

Sean Nash

This is a parameter, not an input.

This is a parameter, not an input.

12:57 pm

Sean Nash

Be explicit (i.e. TRUE == useShortStabilizeTime).

Be explicit (i.e. TRUE == useShortStabilizeTime).

12:57 pm

Sean Nash

Why set to false here? Seems like if statement in next state will always be false now.

Why set to false here? Seems like if statement in next state will always be false now.

12:54 pm

Sean Nash

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

8:50 am

jtaylor  (deleted user)

Please check comment column alignment

Please check comment column alignment

Thursday 17 Aug 2023
1:01 pm

Sean Nash

9:10 am

Sean Nash

Wednesday 16 Aug 2023
1:59 pm

Darren Cox , jtaylor  (deleted user) , wbracken  (deleted user) and Vinayakam Mani

1:51 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:02 am

Sean Nash

Done.

Done.

Tuesday 15 Aug 2023
6:45 pm

wbracken  (deleted user)

Add syringePumpStateStartTime to header.

Add syringePumpStateStartTime to header.

10:24 am

Sean Nash

Monday 14 Aug 2023
4:04 pm

Dara Navaei

HD-DEN-16200_Syringe Pump Stuck IN Priming State
HD-DEN-16200_Syringe Pump Stuck IN Priming State
2:32 pm

jtaylor  (deleted user)