hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Dec 2021
1:14 pm

Sean Nash

Update message list with latest data details.

Update message list with latest data details.

1:13 pm

Sean Nash

Update message list with latest broadcast msg data details.

Update message list with latest broadcast msg data details.

1:09 pm

Sean Nash

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

1:08 pm

Sean Nash

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buf...

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buffer to populate - otherwise it will overwrite memory.

1:03 pm

Sean Nash

.crc?

.crc?

1:00 pm

Sean Nash

1 and 0 is not clear. Better to say FIFO send and reset.

1 and 0 is not clear. Better to say FIFO send and reset.

12:43 pm

Sean Nash

Create and trigger new alarm.

Create and trigger new alarm.

12:42 pm

Sean Nash

.crc?

.crc?

12:40 pm

Sean Nash

Recommend changing > to >= and then removing the - 1.

Recommend changing > to >= and then removing the - 1.

12:28 pm

Sean Nash

Please update message list details for this broadcast msg.

Please update message list details for this broadcast msg.

12:24 pm

Sean Nash

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

12:23 pm

Sean Nash

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

12:21 pm

Sean Nash

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

10:00 am

Dara Navaei

Done.

Done.

9:55 am

Sean Nash

Recommend moving this rate to be with the others above.

Recommend moving this rate to be with the others above.

9:52 am

Sean Nash

STEADY_VOLUME_COUNT_SEC is a number of seconds of stability indicating volume is steady. This only works because sampling time above is once per second. If somebody changes the sampling time, this ...

STEADY_VOLUME_COUNT_SEC is a number of seconds of stability indicating volume is steady. This only works because sampling time above is once per second. If somebody changes the sampling time, this condition will not be right.

9:49 am

Sean Nash

Make 0.5 a #define.

Make 0.5 a #define.

9:43 am

Sean Nash

Can we please use available alarm IDs above before adding a new one?

Can we please use available alarm IDs above before adding a new one?

Thursday 16 Dec 2021
3:29 pm

Behrouz NematiPour

After talking with Hung, This change is currently on his feature branch and should not be changed in here, later which codes are merged it will be resolved in case of conflict.

After talking with Hung,
This change is currently on his feature branch and should not be changed in here,
later which codes are merged it will be resolved in case of conflict.

2:50 pm

hnguyen  (deleted user)

Late breaking news, the HD_PRE_TREATMENT_PRIME_STATE_T has changed. The correct order of the items in enum type of the pre-treatment states are listed below: HD_PRIME_START_STATE = 0, ///< Prime s...

Late breaking news, the HD_PRE_TREATMENT_PRIME_STATE_T has changed.
The correct order of the items in enum type of the pre-treatment states are listed below:

HD_PRIME_START_STATE = 0, ///< Prime start state
HD_PRIME_WAIT_FOR_USER_START_STATE, ///< Wait for user to start prime state
HD_PRIME_SALINE_SETUP_STATE, ///< Saline setup state
HD_PRIME_SALINE_PURGE_AIR_STATE, ///< Saline purge air state
HD_PRIME_SALINE_CIRC_BLOOD_CIRCUIT_STATE, ///< Circulate blood circuit state
HD_PRIME_RESERVOIR_ONE_FILL_COMPLETE_STATE, ///< Wait for reservoir 1 fill complete
HD_PRIME_DIALYSATE_DIALYZER_STATE, ///< Dialysate dialyzer fluid path state
HD_PRIME_SALINE_DIALYZER_SETUP_STATE, ///< Saline dialyzer setup state
HD_PRIME_SALINE_DIALYZER_STATE, ///< Saline dialyzer fluid path state
HD_PRIME_RESERVOIR_TWO_FILL_COMPLETE_STATE, ///< Wait for reservoir 2 fill complete
HD_PRIME_DIALYSATE_BYPASS_STATE, ///< Dialysate bypass fluid path state
HD_PRIME_WET_SELF_TESTS_STATE, ///< Perform wet self-tests after priming complete
HD_PRIME_PAUSE, ///< Prime pause state, waits to be resumed
HD_PRIME_COMPLETE, ///< Prime complete state
NUM_OF_HD_PRIME_STATES ///< Number of prime sub-mode states

Monday 13 Dec 2021
6:19 pm

hnguyen  (deleted user)

Yes, we could use a single variable as the start time in all the pre-treatment states

Yes, we could use a single variable as the start time in all the pre-treatment states

5:31 pm

hnguyen  (deleted user)

Replaced "loadcellSteadyVolumeStartTime" with "steadyVolumeSamplingStartTime"

Replaced "loadcellSteadyVolumeStartTime" with "steadyVolumeSamplingStartTime"

5:13 pm

hnguyen  (deleted user)

Done

Done

5:09 pm

hnguyen  (deleted user)

Done

Done

5:08 pm

hnguyen  (deleted user)

No, loadcellSteadyVolumeStartTime was last set when the primeDialysateDialyzerTimeLimit has just expired.

No, loadcellSteadyVolumeStartTime was last set when the primeDialysateDialyzerTimeLimit has just expired.

4:52 pm

hnguyen  (deleted user)

Done

Done

4:47 pm

hnguyen  (deleted user)

Done

Done

4:47 pm

hnguyen  (deleted user)

Done.

Done.

4:13 pm

Sean Nash

This start time probably needs a new name to better describe what it's doing.

This start time probably needs a new name to better describe what it's doing.

4:10 pm

Sean Nash

Recommend just setting up pumps and valves in this function rather than calling another function.

Recommend just setting up pumps and valves in this function rather than calling another function.