hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
2:05 pm

Dara Navaei

Done.

Done.

1:59 pm

Dara Navaei

Yes, I have a TODO to finish them off in DEN-12224.

Yes, I have a TODO to finish them off in DEN-12224.

1:54 pm

Dara Navaei

Done.

Done.

1:52 pm

Dara Navaei

Done.

Done.

1:51 pm

Dara Navaei

Yes, I tried a release build and it compiled.

Yes, I tried a release build and it compiled.

1:46 pm

Dara Navaei

Done.

Done.

11:39 am

Sean Nash

Magic #.

Magic #.

11:38 am

Sean Nash

Seems we are not consistent about using #ifndef RELEASE. We have it here, but not in the if above on line 400.

Seems we are not consistent about using #ifndef RELEASE. We have it here, but not in the if above on line 400.

11:32 am

Sean Nash

I think we should use <> for library includes. And they should go on top.

I think we should use <> for library includes. And they should go on top.

11:29 am

Sean Nash

Remove blank line. And what is new remove field for?

Remove blank line. And what is new remove field for?

11:19 am

Sean Nash

Have you tried a release build to see if we have this right?

Have you tried a release build to see if we have this right?

11:14 am

Sean Nash

They do not. Remove volatile from these declarations.

They do not. Remove volatile from these declarations.

11:08 am

Sean Nash

Fix indenting here.

Fix indenting here.

Saturday 26 Feb 2022
12:30 pm

Dara Navaei

Sean Nash please reply.

Sean Nash please reply.

12:30 pm

Dara Navaei

Good point, I updated it.

Good point, I updated it.

12:28 pm

Dara Navaei

I uninitialized it.

I uninitialized it.

12:28 pm

Dara Navaei

That is right.

That is right.

12:27 pm

Dara Navaei

Sean Nash please reply.

Sean Nash please reply.

12:27 pm

Dara Navaei

Sean Nash please respond,.

Sean Nash please respond,.

12:26 pm

Dara Navaei

This code has been removed already.

This code has been removed already.

12:23 pm

Dara Navaei

Yes. We might go back to it.

Yes. We might go back to it.

12:23 pm

Dara Navaei

It must be removed.

It must be removed.

Thursday 24 Feb 2022
2:29 pm

Michael Garthwaite

Shouldn't this include be in TaskGeneral.c?

Shouldn't this include be in TaskGeneral.c?

2:24 pm

Michael Garthwaite

Is the commented test code still needed?

Is the commented test code still needed?

2:21 pm

Michael Garthwaite

Venous pressure does not have an error count. Is it needed?

Venous pressure does not have an error count. Is it needed?

2:18 pm

Michael Garthwaite

Do we want to keep this commented out defs?

Do we want to keep this commented out defs?

2:16 pm

Michael Garthwaite

Should 300 be a magic number?

Should 300 be a magic number?

2:04 pm

Michael Garthwaite

Should 300 be a magic number?

Should 300 be a magic number?

2:03 pm

Michael Garthwaite

There are no changes in this file and its not a new file.

There are no changes in this file and its not a new file.

1:48 pm

Michael Garthwaite

Did we ever get clarification on these threshold values?

Did we ever get clarification on these threshold values?