hdfirmware / firmware / App / Modes

ModePreTreat.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Jan 2023
2:23 pm

Darren Cox <darren_m@cox.net>

DEN-14561 Wait for dry self test before final fill. Use reservoir 2 for Prime dialysate bypass.

Options
    • -2
    • +3
    ./ModePreTreat.c
  2. … 1 more file in changeset.
12:38 pm

jtaylor  (deleted user)

Done.

Done.

11:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Darren Cox

Updated to 600.

Updated to 600.

10:30 am

Darren Cox <darren_m@cox.net>

DEN-14561 Update PRE_TREATMENT_FILL_RESERVOIR_TWO_VOLUME_ML per code review comment.

Options
    • -1
    • +1
    ./ModePreTreat.c
Thursday 19 Jan 2023
3:47 pm

Sean Nash

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

3:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:05 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14561

Pretreatment repeated flush implementation update.

Options
    • -45
    • +29
    ./ModePreTreat.c
10:59 am

Darren Cox

Old transfer was 600mL, new is 300mL. Res 1 should end up with 1500 so added 300 to baseline, Res 2 was previously ending with 500. Do we want it to end R2 with 300?

Old transfer was 600mL, new is 300mL. Res 1 should end up with 1500 so added 300 to baseline, Res 2 was previously ending with 500. Do we want it to end R2 with 300?

10:55 am

Darren Cox

Updated for only reservoir 2 fill state.

Updated for only reservoir 2 fill state.

9:27 am

Sean Nash

There are two dialysate prime states. First goes through dialyzer and both DPs are running and we still want 300 rate. Second bypasses dialyzer and only DPi is running and we want 600 rate.

There are two dialysate prime states. First goes through dialyzer and both DPs are running and we still want 300 rate. Second bypasses dialyzer and only DPi is running and we want 600 rate.

9:26 am

Sean Nash

This looks like we're skipping draining of reservoirs before doing any filling if priming disabled. I think we always want to drain both reservoirs first. Also, if we go to fill state like this, wi...

This looks like we're skipping draining of reservoirs before doing any filling if priming disabled. I think we always want to drain both reservoirs first.
Also, if we go to fill state like this, will it do a flush or a normal fill? I think it will do a flush fill since flushed flag is still FALSE.

9:19 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:17 am

Sean Nash

We should initialize these with a loop iterating through each reservoir (in case a reservoir is added/removed at some point).

We should initialize these with a loop iterating through each reservoir (in case a reservoir is added/removed at some point).

9:16 am

Sean Nash

This should probably be 600 since we'll only be transferring 300 to R1 in wet self-tests.

This should probably be 600 since we'll only be transferring 300 to R1 in wet self-tests.

9:02 am

wbracken  (deleted user)

Alignment

Alignment

Wednesday 18 Jan 2023
5:36 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14561

Extended changes that correct RELEASE flag logic

Provide multiple flush passes in pretreatment

And eliminate all flushes when priming is disabled

Options
    • -48
    • +43
    ./ModePreTreat.c
  2. … 1 more file in changeset.
3:29 pm

Darren Cox <darren_m@cox.net>

DEN-14561 Update timing and volumesfor speeding up Pre-Treat part 1.

Options
    • -2
    • +2
    ./ModePreTreat.c
  2. … 2 more files in changeset.
12:38 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:55 am

Darren Cox

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

11:53 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:50 am

Sean Nash

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

11:48 am

Sean Nash

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

11:15 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:13 am

Darren Cox

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

11:08 am

Darren Cox

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

Tuesday 17 Jan 2023
3:53 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off

DEN-14457-reservoir-drains-before-treatment-with-pre-treatment-build-flags-off dragged into current branch

Options
    • -4
    • +4
    ./ModePreTreat.c
2:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:57 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:56 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH