hdfirmware / firmware / App / Modes

ModePreTreat.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Feb 2023
11:52 am

jtaylor  (deleted user)

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Tuesday 31 Jan 2023
6:05 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:45 pm

jtaylor  (deleted user)

Done. We will want to verify that we don't disable all of the resume fill calls.

Done. We will want to verify that we don't disable all of the resume fill calls.

3:42 pm

jtaylor  (deleted user)

Done.

Done.

1:30 pm

Sean Nash

What does flush complete have to do with draining here?

What does flush complete have to do with draining here?

1:26 pm

Sean Nash

We don't want to signal here if we don't have an air pump.

We don't want to signal here if we don't have an air pump.

1:14 pm

jtaylor  (deleted user)

Done.

Done.

1:05 pm

Sean Nash

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

1:00 pm

Sean Nash

Add blank line between declaration and code.

Add blank line between declaration and code.

12:57 pm

Sean Nash

Another way to handle making sure we get past s.t. dry state is to not set startNormalFill on res until op mode state machine gets to s.t. dry state. Then don't need to change this if to consider p...

Another way to handle making sure we get past s.t. dry state is to not set startNormalFill on res until op mode state machine gets to s.t. dry state. Then don't need to change this if to consider pre-tx state.

11:48 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:36 am

Darren Cox

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:20 am

Sean Nash

Fixed.

Fixed.

11:12 am

jtaylor  (deleted user)

Done, initial drain of the reservoirs, prior to syncing with the self-test.

Done, initial drain of the reservoirs, prior to syncing with the self-test.

11:08 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:07 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:01 am

wbracken  (deleted user)

Add alarmActionResumeReceived.

Add alarmActionResumeReceived.

10:58 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:58 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:57 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:19 am

Sean Nash

We are asking DG to set the currently active reservoir as the active reservoir? So no change?

We are asking DG to set the currently active reservoir as the active reservoir? So no change?

9:16 am

Sean Nash

Add spaces around (). And literal should go to right unless using == operator.

Add spaces around (). And literal should go to right unless using == operator.

9:04 am

Sean Nash

Alignment of comment.

Alignment of comment.

9:02 am

Sean Nash

I don't see this being used anywhere. Remove.

I don't see this being used anywhere. Remove.

Monday 30 Jan 2023
8:27 am

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Friday 27 Jan 2023
1:37 pm

Sean Nash

Fixed.

Fixed.

1:37 pm

Sean Nash

Fixed.

Fixed.

11:45 am

Sean Nash

Not required.

Not required.

11:44 am

Sean Nash

Will have you do that when I can merge this branch.

Will have you do that when I can merge this branch.

11:43 am

Sean Nash

Not required.

Not required.