ModePreTreat.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done. We will want to verify that we don't disable all of the resume fill calls.

Done. We will want to verify that we don't disable all of the resume fill calls.

Done.

Done.

What does flush complete have to do with draining here?

What does flush complete have to do with draining here?

We don't want to signal here if we don't have an air pump.

We don't want to signal here if we don't have an air pump.

Done.

Done.

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

Add blank line between declaration and code.

Add blank line between declaration and code.

Another way to handle making sure we get past s.t. dry state is to not set startNormalFill on res until op mode state machine gets to s.t. dry state. Then don't need to change this if to consider p...

Another way to handle making sure we get past s.t. dry state is to not set startNormalFill on res until op mode state machine gets to s.t. dry state. Then don't need to change this if to consider pre-tx state.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Fixed.

Fixed.

Done, initial drain of the reservoirs, prior to syncing with the self-test.

Done, initial drain of the reservoirs, prior to syncing with the self-test.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Add alarmActionResumeReceived.

Add alarmActionResumeReceived.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

We are asking DG to set the currently active reservoir as the active reservoir? So no change?

We are asking DG to set the currently active reservoir as the active reservoir? So no change?

Add spaces around (). And literal should go to right unless using == operator.

Add spaces around (). And literal should go to right unless using == operator.

Alignment of comment.

Alignment of comment.

I don't see this being used anywhere. Remove.

I don't see this being used anywhere. Remove.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Fixed.

Fixed.

Fixed.

Fixed.

Not required.

Not required.

Will have you do that when I can merge this branch.

Will have you do that when I can merge this branch.

Not required.

Not required.