hdfirmware / firmware / App / Modes

ModeStandby.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 14 Dec 2022
9:53 am

Dara Navaei

DEN-14307 added more treatment blockers and added a message to override the NV record CRC. Changed some of the NV record alarms to software fault

Options
    • -12
    • +13
    ./ModeStandby.c
  2. … 5 more files in changeset.
Monday 05 Dec 2022
3:29 pm

Michael Garthwaite

Merge branch 'DEN-14344-sw-s85-mg-dpi-pwmflow-fix' into develop

Options
    • -2
    • +2
    ./ModeStandby.c
  2. … 6 more files in changeset.
2:05 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeStandby.c
  2. … 6 more files in changeset.
2:04 pm

Dara Navaei

2:03 pm

jtaylor  (deleted user) and Sean Nash

1:43 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 02 Dec 2022
4:38 pm

Sean Nash

Created a #define for magic number. Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of de...

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

9:37 am

jtaylor  (deleted user)

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

Thursday 01 Dec 2022
2:35 pm

Dara Navaei

Merged DEN-14252

Options
    • -17
    • +19
    ./ModeStandby.c
  2. … 5 more files in changeset.
1:42 pm

Sean Nash

DEN-14252: Candidate fix for DEN-14254 for syringe DAC issue.

Options
    • -17
    • +19
    ./ModeStandby.c
  2. … 1 more file in changeset.
Tuesday 29 Nov 2022
10:31 am

jtaylor  (deleted user)

10:31 am

Dara Navaei

DEN-14307 added PiSquare's VectorCAST

Options
    • -15
    • +32
    ./ModeStandby.c
  2. … 3 more files in changeset.
Tuesday 22 Nov 2022
4:21 pm

Dara Navaei

HD-DEN-14252_System Self Test Failure Occurs Intermittently
HD-DEN-14252_System Self Test Failure Occurs Intermittently
Monday 21 Nov 2022
8:39 am

Sean Nash

Fixed merge conflicts.

Options
    • -1
    • +1
    ./ModeStandby.c
  2. … 6 more files in changeset.
Friday 18 Nov 2022
4:49 pm

Dara Navaei

Sunday 13 Nov 2022
7:29 pm

Dara Navaei

HD-DEN-14307_DG HD Dev HD DG Dvt Update Part 6
HD-DEN-14307_DG HD Dev HD DG Dvt Update Part 6
Friday 11 Nov 2022
3:31 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeStandby.c
  2. … 10 more files in changeset.
3:23 pm

Dara Navaei

3:21 pm

Dara Navaei

Merged DEN-14150

Options
    • -0
    • +2
    ./ModeStandby.c
  2. … 11 more files in changeset.
3:17 pm

Sean Nash

3:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:04 pm

Dara Navaei

DEN-14150 addressed a code review comment

Options
    • -0
    • +2
    ./ModeStandby.c
  2. … 1 more file in changeset.
2:19 pm

Dara Navaei

Done

Done

1:58 pm

Sean Nash

Need to make sure these only get called once before pre-treatment.

Need to make sure these only get called once before pre-treatment.

1:51 pm

Dara Navaei

DEN-14150 merged staging

Options
    • -30
    • +226
    ./ModeStandby.c
  2. … 6 more files in changeset.
Tuesday 08 Nov 2022
9:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:28 am

Dong Nguyen

Removed. Done.

Removed. Done.

9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:02 am

Sean Nash

Remove extra blank line. Should only be 1 blank line between functions.

Remove extra blank line. Should only be 1 blank line between functions.

Monday 07 Nov 2022
2:08 pm

Dong Nguyen

Done. I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLM...

Done.
I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLMin() instead of using filteredDialinFlowMeterReading.