hdfirmware / firmware / App / Modes

OperationModes.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Mar
5:42 pm

Dara Navaei

DENBUG-302 updated the code to send the UF rate back to the user and wait for the user to accept or reject it

Options
    • -8
    • +8
    ./OperationModes.c
  2. … 2 more files in changeset.
9:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:21 am

Sean Nash

2 blank lines above/below test banner.

2 blank lines above/below test banner.

Tuesday 25 Mar
3:37 pm

Dara Navaei

DENBUG-302 changed the code to send the new calculated UF rate to the user to accpet or reject and then based on that the treatment duration is updated

Options
    • -11
    • +40
    ./OperationModes.c
  2. … 3 more files in changeset.
9:42 am

Dara Navaei

DENBUG-298 addressed the code review comment

Options
    • -11
    • +40
    ./OperationModes.c
  2. … 5 more files in changeset.
9:41 am

Dara Navaei

Done

Done

9:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:37 am

Sean Nash

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

9:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 21 Mar
10:33 am

Sean Nash

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

8:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:44 am

Sean Nash

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

8:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 20 Mar
2:19 pm

Dara Navaei

Done

Done

2:17 pm

Dara Navaei

Done

Done

2:17 pm

Dara Navaei

The saline bolus state is checked in the below else if

The saline bolus state is checked in the below else if

9:11 am

Sean Nash

I think it would be better to reject here if the saline bolus exec is IDLE (indicates there is no saline bolus in progress to abort). I don't want to pend an abort flag (and open pressure limits) w...

I think it would be better to reject here if the saline bolus exec is IDLE (indicates there is no saline bolus in progress to abort).
I don't want to pend an abort flag (and open pressure limits) when no bolus in in progress.

9:07 am

Sean Nash

Also reject if in treatment stop state and recovering from blood leak alarm.

Also reject if in treatment stop state and recovering from blood leak alarm.

9:07 am

Sean Nash

Why doesn't treatment stop publish saline bolus (like dialysis)?

Why doesn't treatment stop publish saline bolus (like dialysis)?

9:05 am

Sean Nash

Do we reject saline bolus request if blood leak recovery is in progress? I think we should. I don't want a saline bolus requesting pending while blood leak recover is happening.

Do we reject saline bolus request if blood leak recovery is in progress? I think we should. I don't want a saline bolus requesting pending while blood leak recover is happening.

Tuesday 18 Mar
1:32 pm

Sean Nash

Change to "available" properties (e.g. priority low).

Change to "available" properties (e.g. priority low).

1:30 pm

Sean Nash

Execute TODO.

Execute TODO.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:49 am

Dara Navaei

Yes

Yes

10:46 am

Sean Nash

Did you remove this reject reason enum?

Did you remove this reject reason enum?

10:46 am

Dara Navaei

Done

Done

10:45 am

Sean Nash

Update comment to remove max.

Update comment to remove max.

9:11 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.