hdfirmware / firmware / App / Modes

OperationModes.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Apr
3:01 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./OperationModes.c
  2. … 19 more files in changeset.
2:57 pm

Dara Navaei

1:56 pm

Michael Garthwaite and Sean Nash

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:47 pm

Dara Navaei

Done

Done

12:37 pm

Sean Nash

Bad practice to have two calls to same function here. Possible that 2nd call will return different result. Should call function once to assign value to a local var prior to if statement and then re...

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.

12:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

Dara Navaei

Yes. I think we should have these events to information.

Yes. I think we should have these events to information.

Thursday 03 Apr
9:00 am

Sean Nash

Are these permanent?

Are these permanent?

Wednesday 02 Apr
3:21 pm

Dara Navaei

DENBUG-302 updated the confirmation function to receive the 4 payloads to be sent up

Options
    • -5
    • +5
    ./OperationModes.c
  2. … 4 more files in changeset.
Tuesday 01 Apr
8:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 31 Mar
9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 28 Mar
8:52 pm

Dara Navaei

DENBUG-302 added more comments

Options
    • -0
    • +2
    ./OperationModes.c
1:17 pm

Sean Nash

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

1:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:15 pm

Dara Navaei

Moved it to OperationModes

Moved it to OperationModes

1:14 pm

Dara Navaei

DENBUG-302 updated the code to check for the UF rate confirmation in operation mode. DEN-17237 changed the code to re-trigger the placeholder cleaning mode alarms if they got cleared

Options
    • -0
    • +2
    ./OperationModes.c
  2. … 3 more files in changeset.
11:00 am

Sean Nash

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we foll...

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

10:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 27 Mar
6:01 pm

Dara Navaei

DENBUG-302 continued with the changes for the UF rate screen support

Options
    • -15
    • +13
    ./OperationModes.c
  2. … 9 more files in changeset.
Wednesday 26 Mar
5:52 pm

Dara Navaei

Done

Done

5:42 pm

Dara Navaei

DENBUG-302 updated the code to send the UF rate back to the user and wait for the user to accept or reject it

Options
    • -8
    • +8
    ./OperationModes.c
  2. … 2 more files in changeset.
9:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:21 am

Sean Nash

2 blank lines above/below test banner.

2 blank lines above/below test banner.

Tuesday 25 Mar
3:37 pm

Dara Navaei

DENBUG-302 changed the code to send the new calculated UF rate to the user to accpet or reject and then based on that the treatment duration is updated

Options
    • -11
    • +40
    ./OperationModes.c
  2. … 3 more files in changeset.
9:42 am

Dara Navaei

DENBUG-298 addressed the code review comment

Options
    • -11
    • +40
    ./OperationModes.c
  2. … 5 more files in changeset.
9:41 am

Dara Navaei

Done

Done

9:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:37 am

Sean Nash

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

9:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.