Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8103: Addressed code review

  1. … 2 more files in changeset.
Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface. Sample water sub-mode has to check before DG started.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

Merge branch 'DEN-7605-hd_dg_dev-self-tests' into develop

  1. … 4 more files in changeset.
DEN-7605: Added POST test for alarm audio.

  1. … 4 more files in changeset.
Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Is this different than alarmStatus.noNewTreatment?

Is this different than alarmStatus.noNewTreatment?

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Moved FPGA POST to last test.

Removed.

Removed.

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have...

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have room for more than 50 alarms. Maybe high priority could be 1..499, medium priority 500..599, and low priority 600..699.

Dara, do we need these handlers or not?

Dara, do we need these handlers or not?

We should delete this dead code as well.

We should delete this dead code as well.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-7605: Added flow sensor comm errors.

  1. … 4 more files in changeset.
DEN-8103: Added mismatch check for alarm enum and alarm table

  1. … 2 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-8103: Initial alarm list implementation

  1. … 5 more files in changeset.
Merge branch 'DEN-7605-hd_dg_dev-self-tests' into develop

  1. … 2 more files in changeset.
DEN-7605: Added placeholder for s/w integrity POST test.

DEN-7605: Added reservoir mgmt changes to prevent UF overfill of reservoir.

  1. … 2 more files in changeset.
Fixed merge conflicts.

  1. … 6 more files in changeset.
DEN-7605: Added POST messaging.

  1. … 3 more files in changeset.
DEN-7860: Corrected spelling issue