Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15104 Updates per code review.

  1. … 2 more files in changeset.
This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

Corrected

Corrected

Removed

Removed

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

They were used when FE OE generated software fault. Removed.

They were used when FE OE generated software fault. Removed.

Removed.

Removed.

Cut and paste error from DG. Corrected.

Cut and paste error from DG. Corrected.

Removed. Replaced fpgaReadByteSize with sizeof( FPGA_SENSORS_T ) in the two statements that it was being used.

Removed. Replaced fpgaReadByteSize with sizeof( FPGA_SENSORS_T ) in the two statements that it was being used.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Nothing else needs to be done.

Nothing else needs to be done.

Remove blank line.

Remove blank line.

Do we need to check for these in out exec?

Do we need to check for these in out exec?

Are these used anywhere?

Are these used anywhere?

Add space between ( and TRUE. Or just remove condition and always set flag to FALSE here.

Add space between ( and TRUE. Or just remove condition and always set flag to FALSE here.

Remove blank line.

Remove blank line.

Use enums instead of literals.

Use enums instead of literals.

Don't we have an enum for these values?

Don't we have an enum for these values?

Is there more to be done here (TODO)?

Is there more to be done here (TODO)?

I think these variable declarations should stay here. Why move to function?

I think these variable declarations should stay here. Why move to function?

This is HD f/w. Why are you looking at DG mode?

This is HD f/w. Why are you looking at DG mode?

Why aren't these declared at top of file and initialized in init function like everything else.

Why aren't these declared at top of file and initialized in init function like everything else.

DEN-15014 Changes to support FPGA testing. Move FE and OE SCI faults to FPGA communications alarm.

  1. … 8 more files in changeset.
Why is this in two places? And why set every 10ms when it appears to be constant?

Why is this in two places? And why set every 10ms when it appears to be constant?

This doesn't seem to ever change. Why not just initialize this value once on reset?

This doesn't seem to ever change. Why not just initialize this value once on reset?

Make U32.

Make U32.

HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits