hdfirmware / firmware / App / Services

FPGA.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 May 2023
2:25 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./FPGA.c
  2. … 10 more files in changeset.
1:43 pm

wbracken  (deleted user)

11:35 am

Darren Cox , jtaylor  (deleted user) and Sean Nash

Sunday 14 May 2023
3:26 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15104 Update per code review

Options
    • -1
    • +1
    ./FPGA.c
3:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:09 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:48 pm

wbracken  (deleted user)

Moved to here from function.

Moved to here from function.

11:48 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15104 Updates per code review.

Options
    • -4
    • +5
    ./FPGA.c
11:28 am

wbracken  (deleted user)

No longer needed.

No longer needed.

Friday 12 May 2023
5:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:32 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:29 pm

Sean Nash

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

5:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:28 pm

Sean Nash

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

5:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

Now it's gone. No longer needed?

Now it's gone. No longer needed?

1:48 pm

wbracken  (deleted user)

Removed

Removed

1:47 pm

wbracken  (deleted user)

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the...

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the enum but is the second 2nd group of 3 bits (0 relative) returned by the FPGA.

1:41 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15104 Updates per code review.

Options
    • -12
    • +4
    ./FPGA.c
  2. … 2 more files in changeset.
1:39 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:33 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:31 pm

wbracken  (deleted user)

Corrected

Corrected

1:21 pm

wbracken  (deleted user)

Removed

Removed