SystemComm.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Fixed.

Fixed.

Fixed.

Fixed.

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead. Otherwise, I like to put the literal last because it reads be...

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead.
Otherwise, I like to put the literal last because it reads better.

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the ...

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the two values that you are toggling between.

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety. So the way I have it now, if isBloodPumpRunning() g...

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety.
So the way I have it now, if isBloodPumpRunning() gets corrupted to > 1, it will consider that the pump is not running which is the safer thing to do.

currentSubMode is already a U32 - no cast needed.

currentSubMode is already a U32 - no cast needed.

Shouldn't be? ( FALSE == isBloodPumpRunning() )

Shouldn't be?

( FALSE == isBloodPumpRunning() )
why here currentMode is casted while currentSubMode didn't? data.opMode = (U32)currentMode; data.subMode = currentSubMode;

why here
currentMode is casted while currentSubMode didn't?

data.opMode = (U32)currentMode;
data.subMode = currentSubMode;
Does a toggle function/macro need the second and third parameters, since whatever value it currently has should be reversed?

Does a toggle function/macro need the second and third parameters, since whatever value it currently has should be reversed?

Could you please explain why the ack timeout increased, is it for POST ack issues or there were other things too?

Could you please explain why the ack timeout increased, is it for POST ack issues or there were other things too?

should be if ( TRUE != getRinsebackCompleted() ) for consistency

should be if ( TRUE != getRinsebackCompleted() ) for consistency

add last else else { }

add last else
else
{

}

Fixed.

Fixed.

per MISRA, need the else statement at the end of if { }- else if { } - else if { }- else { }

per MISRA, need the else statement at the end of if { }- else if { } - else if { }- else { }

This file is missing a file header

This file is missing a file header

Add file header

Add file header

Add file header

Add file header

Add file header

Add file header

Add file header

Add file header

Fixed.

Fixed.