hdfirmware / firmware / App / Services

SystemComm.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Nov 2021
1:40 pm

Sean Nash

What is the status of these commented out lines of code? Are we removing or keeping?

What is the status of these commented out lines of code? Are we removing or keeping?

1:39 pm

Sean Nash

What is the status of this line of code? Are we removing it or keeping it?

What is the status of this line of code? Are we removing it or keeping it?

1:38 pm

Sean Nash

Align comment.

Align comment.

1:38 pm

Sean Nash

Need to restore this code.

Need to restore this code.

1:37 pm

Sean Nash

Need to restore this code.

Need to restore this code.

1:37 pm

Sean Nash

Why do I not see a call to this function in SystemComm.c?

Why do I not see a call to this function in SystemComm.c?

1:34 pm

Sean Nash

Either testSetStopRTC() should return a BOOL and set result to that BOOL or you need to just set result to TRUE in this if scope - otherwise the Ack sent below will always be a Nak.

Either testSetStopRTC() should return a BOOL and set result to that BOOL or you need to just set result to TRUE in this if scope - otherwise the Ack sent below will always be a Nak.

Monday 08 Nov 2021
1:21 pm

Behrouz NematiPour

Saturday 06 Nov 2021
7:04 pm

Dara Navaei

HD-DEN-9480_DG_DEV Dialysate Temperature Control
HD-DEN-9480_DG_DEV Dialysate Temperature Control
Friday 05 Nov 2021
7:09 pm

Behrouz NematiPour

I couldn't find TBD anywhere in the code!!! What is TBD?

I couldn't find TBD anywhere in the code!!!
What is TBD?

Thursday 04 Nov 2021
8:50 am

Sean Nash

There is nothing to be done in else, so why add it?

There is nothing to be done in else, so why add it?

8:49 am

Sean Nash

There is nothing to be done in else, so why add it?

There is nothing to be done in else, so why add it?

Monday 01 Nov 2021
10:19 am

Sean Nash

Added file header.

Added file header.

Wednesday 27 Oct 2021
10:48 am

hnguyen  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:48 am

hnguyen  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:48 am

hnguyen  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:47 am

hnguyen  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:45 am

hnguyen  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:40 am

Behrouz NematiPour

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

10:39 am

Behrouz NematiPour

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

10:37 am

Behrouz NematiPour

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

10:36 am

Behrouz NematiPour

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

8:49 am

Sean Nash

Fixed.

Fixed.

8:43 am

Sean Nash

Fixed.

Fixed.

8:41 am

Sean Nash

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead. Otherwise, I like to put the literal last because it reads be...

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead.
Otherwise, I like to put the literal last because it reads better.

8:38 am

Sean Nash

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

8:36 am

Sean Nash

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the ...

This toggle macro is designed to be generic - so does not assume you are toggling between 0 and 1. Could be toggling between ON and OFF or OPEN and CLOSED, etc... So you have to give the macro the two values that you are toggling between.

8:34 am

Sean Nash

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety. So the way I have it now, if isBloodPumpRunning() g...

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety.
So the way I have it now, if isBloodPumpRunning() gets corrupted to > 1, it will consider that the pump is not running which is the safer thing to do.

8:30 am

Sean Nash

currentSubMode is already a U32 - no cast needed.

currentSubMode is already a U32 - no cast needed.

Tuesday 26 Oct 2021
10:24 pm

Behrouz NematiPour

Shouldn't be? ( FALSE == isBloodPumpRunning() )

Shouldn't be?

( FALSE == isBloodPumpRunning() )