SystemComm.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Removed.

Removed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH, no change

RESOLVED in CODE WALKTHROUGH, no change

RESOLVED in CODE WALKTHROUGH, no change

RESOLVED in CODE WALKTHROUGH, no change

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

Restore this blank line.

Restore this blank line.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

FIXED IN CODE WALKTHROUGH

FIXED IN CODE WALKTHROUGH

Remove blank line.

Remove blank line.

i think there's a conflict between staging and develop. fixed for staging merge. thanks!

i think there's a conflict between staging and develop. fixed for staging merge. thanks!

originally wanted to change setDialInPumpTargetFlowRate() to have the same conditions as testSetDialInPWM but we can integrate it later pending Darren's results.

originally wanted to change setDialInPumpTargetFlowRate() to have the same conditions as testSetDialInPWM but we can integrate it later pending Darren's results.

Fixed. Thanks!

Fixed. Thanks!

Fixed. moved to testSetDialInPumpWithPWM(). Thanks!

Fixed. moved to testSetDialInPumpWithPWM(). Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. This condition requires that the Pump is flagged off. that same condition is also used below. we will always be true in the first condition below if we satisfy this condition. If we try to c...

Fixed. This condition requires that the Pump is flagged off. that same condition is also used below. we will always be true in the first condition below if we satisfy this condition. If we try to change direction when the pump is on, both this condition and the one below will fail.

Where did this enum name change take place? There is no common in this code review.

Where did this enum name change take place? There is no common in this code review.