hdfirmware / firmware / App / Services

SystemComm.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 10 Mar 2023
3:58 pm

Dara Navaei and wbracken  (deleted user)

3:41 pm

Dara Navaei

HD-DEN-14918_Pba Pbo And OB Not Available ON Debug Screen
HD-DEN-14918_Pba Pbo And OB Not Available ON Debug Screen
1:20 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:19 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:18 pm

wbracken  (deleted user)

Isn't deleted statement correct?

Isn't deleted statement correct?

1:17 pm

wbracken  (deleted user)

Isn't delete statement correct?

Isn't delete statement correct?

10:19 am

Sean Nash

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACK...

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACKing (TRUE) or NAKing (FALSE) this command). Here, we are NAKing the command, so FALSE was appropriate.

10:16 am

Sean Nash

Has DG check-in msg ID been made available for re-purpose? RESOLVED in CODE WALKTHROUGH.

Has DG check-in msg ID been made available for re-purpose?
RESOLVED in CODE WALKTHROUGH.

10:14 am

Michael Garthwaite

DG no longer sends this message. We determine DG check-in by receiving the DG op mode command.

DG no longer sends this message. We determine DG check-in by receiving the DG op mode command.

10:01 am

Dara Navaei

HD-DEN-14888_Unable TO Trigger Alarm 47 Ultrafiltration Rate IS Too High Error During Treatment
HD-DEN-14888_Unable TO Trigger Alarm 47 Ultrafiltration Rate IS Too High Error During Treatment
9:48 am

Sean Nash

Why removed?

Why removed?

Thursday 09 Mar 2023
11:35 am

wbracken  (deleted user)

Change cmd to prompt

Change cmd to prompt

11:08 am

Michael Garthwaite

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness. If set to false, the output is: 0x4A MSG_ID_UI_PATI...

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness.

If set to false, the output is:

0x4A MSG_ID_UI_PATIENT_DISCONNECTION_CONFIRM hdfirmware response COMM_BUFFER_OUT_CAN_HD_2_UI ACK_REQUIRED PAYLOAD

which is incorrect to what the code is doing. We have 2 different implementations of calling sendAckResponseMsg()


1. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, FALSE );

  1. if we dont meet an expected condition. Later in the handler we will call a response message with the response message calling:
    serializeMessage( msg, COMM_BUFFER_OUT_CAN_DG_2_HD, ACK_REQUIRED );


2. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, result );

  1. a conditional based on?


Please review the FW_Message_list.csv within latest develop & staging builds to understand how the automated script is determining "ack requireness"

Wednesday 08 Mar 2023
7:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:08 pm

Sean Nash

FALSE was right.

FALSE was right.

7:03 pm

Sean Nash

Add space after "(".

Add space after "(".

7:01 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

7:00 pm

Sean Nash

Add blank line before comment.

Add blank line before comment.

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:42 am

Michael Garthwaite

FALSE will be determined by our automagic script to be ACK_REQUIRED in the excel sheet. This will cause discrepancies between the readers of that sheet and what the FW does.

FALSE will be determined by our automagic script to be ACK_REQUIRED in the excel sheet. This will cause discrepancies between the readers of that sheet and what the FW does.

Monday 06 Mar 2023
9:41 am

jtaylor  (deleted user)

Monday 27 Feb 2023
10:51 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:51 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:36 am

Sean Nash

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structur...

Compiler will align structures to 32-bits by default. Use "#pragma pack(push,1)" above structure declaration and "#pragma pack(pop)" below declaration to tell the compiler to pack/compress structures to 1 byte (8-bit) alignment.

10:30 am

Michael Garthwaite

Can you clarify? Is U08 no longer the size of 1 byte?

Can you clarify? Is U08 no longer the size of 1 byte?

10:23 am

Sean Nash

Should pack structure to 1 byte so sizeof() gives you 1 byte size.

Should pack structure to 1 byte so sizeof() gives you 1 byte size.