hdfirmware / firmware / App / Services

SystemCommMessages.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 11 May 2021
11:50 am

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: Finished implementing HD Air Bubble Detectors

Options
    • -3
    • +38
    ./SystemCommMessages.c
  2. … 6 more files in changeset.
10:50 am

qnguyen  (deleted user)

Why should we need a separate mask for bubble test state? I thought the normal input status mask should be sufficient to see the faked air bubble.

Why should we need a separate mask for bubble test state? I thought the normal input status mask should be sufficient to see the faked air bubble.

10:48 am

qnguyen  (deleted user)

Incorrect enum.

Incorrect enum.

10:46 am

qnguyen  (deleted user)

Incorrect casting type.

Incorrect casting type.

10:45 am

qnguyen  (deleted user)

Re-word comment.

Re-word comment.

10:43 am

qnguyen  (deleted user)

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

10:43 am

qnguyen  (deleted user)

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

10:41 am

qnguyen  (deleted user)

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

10:37 am

qnguyen  (deleted user)

These declarations seem odd. Please re-check.

These declarations seem odd. Please re-check.

10:31 am

qnguyen  (deleted user)

These should be bit 2 (0x04) and bit 3 (0x08).

These should be bit 2 (0x04) and bit 3 (0x08).

Monday 10 May 2021
2:22 pm

Dara Navaei

2:22 pm

Dara Navaei

HD-DEN-7860_HD Dev Bubble Detector Driver
HD-DEN-7860_HD Dev Bubble Detector Driver
1:31 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: First pass at HD air bubble detectors code

Options
    • -0
    • +90
    ./SystemCommMessages.c
  2. … 6 more files in changeset.
Friday 07 May 2021
6:17 pm

Dara Navaei

Merged DEN-8030

Options
    • -4
    • +187
    ./SystemCommMessages.c
  2. … 9 more files in changeset.
3:16 pm

Dara Navaei

DEN-8030 updated the valves controller

Options
    • -0
    • +32
    ./SystemCommMessages.c
  2. … 7 more files in changeset.
10:23 am

Sean Nash

Fixed merge conflicts.

Options
    • -0
    • +10
    ./SystemCommMessages.c
  2. … 2 more files in changeset.
10:19 am

Sean Nash

DEN-7605: Added build switches.

Options
    • -0
    • +10
    ./SystemCommMessages.c
  2. … 5 more files in changeset.
12:07 am

qnguyen  (deleted user)

Need to remove this comment.

Need to remove this comment.

12:07 am

qnguyen  (deleted user)

Need to remove this comment.

Need to remove this comment.

12:06 am

qnguyen  (deleted user)

Same as comment from DialinFlow.c

Same as comment from DialinFlow.c

12:06 am

qnguyen  (deleted user)

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again. Suggest creating a ...

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again.
Suggest creating a BOOL variable to have all three conditions or with each other and call isPersistentAlarmTriggered() only once.

Thursday 06 May 2021
10:27 am

Sean Nash

initBloodPrime() is called every time we transition to blood prime sub-mode.

initBloodPrime() is called every time we transition to blood prime sub-mode.

Wednesday 05 May 2021
7:57 pm

qnguyen  (deleted user)

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

1:37 pm

Sean Nash

Fixed merge conflicts.

Options
    • -0
    • +128
    ./SystemCommMessages.c
  2. … 4 more files in changeset.
Tuesday 04 May 2021
10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.