SystemCommMessages.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7860: Finished implementing HD Air Bubble Detectors

  1. … 6 more files in changeset.
Why should we need a separate mask for bubble test state? I thought the normal input status mask should be sufficient to see the faked air bubble.

Why should we need a separate mask for bubble test state? I thought the normal input status mask should be sufficient to see the faked air bubble.

Incorrect enum.

Incorrect enum.

Incorrect casting type.

Incorrect casting type.

Re-word comment.

Re-word comment.

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

Recommend converting to a local variable rather than an array.

These declarations seem odd. Please re-check.

These declarations seem odd. Please re-check.

These should be bit 2 (0x04) and bit 3 (0x08).

These should be bit 2 (0x04) and bit 3 (0x08).

HD-DEN-7860_HD Dev Bubble Detector Driver
HD-DEN-7860_HD Dev Bubble Detector Driver
DEN-7860: First pass at HD air bubble detectors code

  1. … 6 more files in changeset.
Merged DEN-8030

  1. … 9 more files in changeset.
DEN-8030 updated the valves controller

  1. … 7 more files in changeset.
Fixed merge conflicts.

  1. … 2 more files in changeset.
DEN-7605: Added build switches.

  1. … 5 more files in changeset.
Need to remove this comment.

Need to remove this comment.

Need to remove this comment.

Need to remove this comment.

Same as comment from DialinFlow.c

Same as comment from DialinFlow.c

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again. Suggest creating a ...

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again.
Suggest creating a BOOL variable to have all three conditions or with each other and call isPersistentAlarmTriggered() only once.

initBloodPrime() is called every time we transition to blood prime sub-mode.

initBloodPrime() is called every time we transition to blood prime sub-mode.

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Fixed merge conflicts.

  1. … 4 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.