hdfirmware / firmware / App / Services

SystemCommMessages.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 11 Mar 2022
10:56 am

Michael Garthwaite

10:36 am

Sean Nash

Where is 0xA04E?

Where is 0xA04E?

Thursday 10 Mar 2022
4:13 pm

Dara Navaei

HD-DEN-12121_SW Dev Sprint 65
HD-DEN-12121_SW Dev Sprint 65
10:19 am

Darren Cox

Added exception for Stopped sub states and before door should be closed.

Added exception for Stopped sub states and before door should be closed.

10:16 am

Darren Cox

Added

Added

10:16 am

Darren Cox

Added.

Added.

10:16 am

Darren Cox

Added.

Added.

10:15 am

Darren Cox

Good catch. Updated.

Good catch. Updated.

10:14 am

Darren Cox

Moved and used getSwitchStatus to ensure overrides work.

Moved and used getSwitchStatus to ensure overrides work.

Wednesday 09 Mar 2022
2:47 pm

Darren Cox

Sean said leave it as is. No harm to be done.

Sean said leave it as is. No harm to be done.

2:31 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:31 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:31 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:16 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:15 pm

Michael Garthwaite

Double #include. It is already written in SystemCommMessages.h

Double #include. It is already written in SystemCommMessages.h

11:50 am

Michael Garthwaite

Fixed. Changed Msg_id for this cmd to 0xA008 to prevent conflicts.

Fixed. Changed Msg_id for this cmd to 0xA008 to prevent conflicts.

11:27 am

Darren Cox

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

Tuesday 08 Mar 2022
4:34 pm

Michael Garthwaite

Similiar to how the check is done in ModePostTreat.c, I think we should check if the heparin parameters are > 0.0 than NEARLY_ZERO.

Similiar to how the check is done in ModePostTreat.c, I think we should check if the heparin parameters are > 0.0 than NEARLY_ZERO.

4:33 pm

Michael Garthwaite

Out of scope of the changes here but hepRate should be getting TREATMENT_PARAM_HEPARIN_DISPENSE_RATE instead of TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME.

Out of scope of the changes here but hepRate should be getting TREATMENT_PARAM_HEPARIN_DISPENSE_RATE instead of TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME.

4:28 pm

Sean Nash

Should we check pump track switch too?

Should we check pump track switch too?

4:28 pm

Sean Nash

Should we check pump track switch too?

Should we check pump track switch too?

4:26 pm

Sean Nash

Why does door need to be closed for this state?

Why does door need to be closed for this state?

4:24 pm

Sean Nash

Do we want to check pump track switch too?

Do we want to check pump track switch too?

4:23 pm

Sean Nash

I think you have these switch checks in the right pre-treatment sub-modes, but I think each of these sub-modes will have a "stopped" state in its state machine where it will go if an alarm occurs a...

I think you have these switch checks in the right pre-treatment sub-modes, but I think each of these sub-modes will have a "stopped" state in its state machine where it will go if an alarm occurs and in that state the user should be allowed to open the door to possibly address the issue.
So I think we need to figure out how to exempt those alarm states.

4:07 pm

Sean Nash

If I understand what you did here, I think we're good updating from HALCoGen w/o breaking the build but if we change stack size(s) we will need to manually update the #if 1 section accordingly afte...

If I understand what you did here, I think we're good updating from HALCoGen w/o breaking the build but if we change stack size(s) we will need to manually update the #if 1 section accordingly after HALCoGen updates this file.

3:59 pm

Sean Nash

I don't think this is the right place to clear alarm conditions. This area of code is updating the actual detected switch states. But switch states are overridable so we should consider any overrid...

I don't think this is the right place to clear alarm conditions. This area of code is updating the actual detected switch states. But switch states are overridable so we should consider any overrides when clearing alarm conditions.

Sunday 06 Mar 2022
8:57 pm

Dara Navaei

Align the comment.

Align the comment.

8:43 pm

Dara Navaei

Why was this include removed? Do you not need it for the treatment parameters commands?

Why was this include removed? Do you not need it for the treatment parameters commands?

8:38 pm

Dara Navaei

This should be a BOOL since you are suing this as a boolean.

This should be a BOOL since you are suing this as a boolean.

Friday 04 Mar 2022
9:37 pm

Dara Navaei

HD-DEN-12215_SW Dev Sprint 65 Darren
HD-DEN-12215_SW Dev Sprint 65 Darren