SystemCommMessages.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged DEN-13460

  1. … 6 more files in changeset.
DEN-13460: Added HD request at boot up for DG to re-send any active alarms that HD may have missed (DEN-13559).

  1. … 2 more files in changeset.
DEN-13460: Added handling of request to re-send HD alarms. Expanded CAN message buffer sizes.

  1. … 6 more files in changeset.
Why removed?

Why removed?

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

F has been added.

F has been added.

No. Code removed.

No. Code removed.

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

Remove blank line.

Remove blank line.

Can we remove this now?

Can we remove this now?

Why?

Why?

Why?

Why?

HD-DEN-13141_Miscellaneous HD Issues BB
HD-DEN-13141_Miscellaneous HD Issues BB
Merged DEN-13460

  1. … 8 more files in changeset.
DEN-13460 updated the code with DVT changes

  1. … 7 more files in changeset.
Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

Need #define for minimum vRef

Need #define for minimum vRef

Is the data being published elsewhere?

Is the data being published elsewhere?

Is this supposed to have been removed.

Is this supposed to have been removed.

DEN-12931: Changed syringe pump calibration to expected DAC voltage. Added verification of calibration.

  1. … 2 more files in changeset.
indent of cases looks too small.

indent of cases looks too small.

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Update input/outputs throughout.

Update input/outputs throughout.

Add blank line before return.

Add blank line before return.

DEN-12931: Added request for UI POST final result to ensure we get result before its needed in UI POST test.

  1. … 2 more files in changeset.
Do we want to keep this debug & sprintf?

Do we want to keep this debug & sprintf?

HD-DEN-12931_DG HD Dev HD DG Dvt Update
HD-DEN-12931_DG HD Dev HD DG Dvt Update
Merge remote-tracking branch 'origin/DEN-13141-miscellaneous_hd_issues_bb' into develop

  1. … 1 more file in changeset.