hdfirmware / firmware / App / Services

SystemCommMessages.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 14 Dec 2022
10:34 am

Sean Nash

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' into develop

Options
    • -9
    • +93
    ./SystemCommMessages.c
  2. … 5 more files in changeset.
9:53 am

Dara Navaei

DEN-14307 added more treatment blockers and added a message to override the NV record CRC. Changed some of the NV record alarms to software fault

Options
    • -2
    • +86
    ./SystemCommMessages.c
  2. … 5 more files in changeset.
Friday 02 Dec 2022
10:55 am

Dara Navaei

Please add comment.

Please add comment.

Tuesday 29 Nov 2022
10:31 am

jtaylor  (deleted user)

10:31 am

Dara Navaei

DEN-14307 added PiSquare's VectorCAST

Options
    • -7
    • +7
    ./SystemCommMessages.c
  2. … 3 more files in changeset.
Monday 28 Nov 2022
4:17 pm

wbracken  (deleted user)

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

4:05 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:02 pm

Michael Garthwaite

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

1:53 pm

wbracken  (deleted user)

Is this an output file from HalCoGen? If so seems like one shouldn't need to modify this file directly.

Is this an output file from HalCoGen? If so seems like one shouldn't need to modify this file directly.

Wednesday 23 Nov 2022
1:19 pm

wbracken  (deleted user)

AirPump.h should be before AirTrap.h.

AirPump.h should be before AirTrap.h.

9:28 am

Michael Garthwaite

Function removed. Thanks!

Function removed. Thanks!

9:27 am

Michael Garthwaite

Function Removed. Thanks!

Function Removed. Thanks!

9:27 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:27 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:27 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:26 am

Michael Garthwaite

Function removed. Thanks!

Function removed. Thanks!

9:26 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:26 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:19 am

Michael Garthwaite

Do we have an alternative to reading if we successfully set the pin high/low?

Do we have an alternative to reading if we successfully set the pin high/low?

Tuesday 22 Nov 2022
9:40 am

Sean Nash

Ok. Not sure how HALCoGen got ahead of generated code for a time. RESOLVED in CODE WALKTHROUGH.

Ok. Not sure how HALCoGen got ahead of generated code for a time.
RESOLVED in CODE WALKTHROUGH.

9:30 am

Sean Nash

Oh, ok. Then somebody removed a blank line previously and should not have. RESOLVED in CODE WALKTHROUGH.

Oh, ok. Then somebody removed a blank line previously and should not have.
RESOLVED in CODE WALKTHROUGH.

9:27 am

Sean Nash

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump direc...

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump directly.

9:25 am

Sean Nash

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

9:24 am

Sean Nash

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

9:22 am

Sean Nash

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

9:21 am

Sean Nash

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.