Activity hdfirmware/firmware/App/Services/SystemCommMessages.c

11:02 am

Dara Navaei

More
0444258
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 292 more HD-DEN-14497-12

DEN-14497, DEN-14326 Added a function to regularly schedule the informative blood leak embedded mode commands. Changed the FALSE to ACk not required in some of the message ack functions

- -29
- +31
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 3 more files in changeset.

11:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

11:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

11:10 am

Michael Garthwaite

More
Re: HD-DEN-14344-3
replied to Sean Nash

Fixed. Thanks!

11:10 am

Michael Garthwaite

More
Re: HD-DEN-14344-3
replied to Sean Nash

Fixed. Thanks!

11:09 am

jtaylor (deleted user)

More
HD-DEN-14344-3
resumed reviewing

9:47 am

Sean Nash

More
Re: HD-DEN-14344-3
commented on review

For a release build, looks like we would do nothing and get stuck in this state.

9:45 am

Sean Nash

More
Re: HD-DEN-14344-3
commented on review

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

8:57 am

Dara Navaei

More
HD-DEN-14497-12
started review

HD-DEN-14497_DG HD Dev HD DG Dvt Update Part 7

1:35 pm

Michael Garthwaite

Fixed. Thanks!

1:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

1:29 pm

Michael Garthwaite

More
Re: HD-DEN-14344-3
replied to Sean Nash

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

1:27 pm

Sean Nash

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

1:25 pm