hdfirmware / firmware / App / Services

SystemCommMessages.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 06 Oct 2022
10:47 am

Sean Nash

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

Tuesday 04 Oct 2022
5:53 pm

Sean Nash

Why not checking payload length?

Why not checking payload length?

5:52 pm

Sean Nash

Keep blank line.

Keep blank line.

5:48 pm

Sean Nash

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers...

These FPGA registers are obsolete - h/w is no longer in our design. Need to continue to maintain register space since registers after these have not moved. You can think of these obsolete registers as "reserved" for future purpose.
Dara, I do think we could rename these register fields to something like Reserved1, Reserved2, ...

5:43 pm

Sean Nash

Monitor execs should be before operation modes exec.

Monitor execs should be before operation modes exec.

5:37 pm

Sean Nash

Why was blank line removed?

Why was blank line removed?

5:29 pm

Sean Nash

Align "=".

Align "=".

5:27 pm

Sean Nash

Add another blank line here.

Add another blank line here.

5:22 pm

Sean Nash

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

Idea is to re-purpose these (instead of adding new alarms to bottom of enum). We prefer not to collapse the table when an alarm ID goes obsolete so other alarm IDs do not change.

11:07 am

wbracken  (deleted user)

What is the significance of (OBSOLETE)? Applies to several blocks.

What is the significance of (OBSOLETE)? Applies to several blocks.

Monday 03 Oct 2022
10:48 am

wbracken  (deleted user)

fpgaPersistentAlarmGroup is an input.

fpgaPersistentAlarmGroup is an input.

10:44 am

wbracken  (deleted user)

Are all available ALARM_IDs being removed?

Are all available ALARM_IDs being removed?

Friday 30 Sep 2022
9:00 am

Michael Garthwaite

Do we want this checked into staging?

Do we want this checked into staging?

Thursday 29 Sep 2022
5:17 pm

Sean Nash

These are defined in the Code Composer project for DG and HD firmware respectively. You can only have one defined and you must have one defined.

These are defined in the Code Composer project for DG and HD firmware respectively. You can only have one defined and you must have one defined.

5:06 pm

Sean Nash

What is the purpose of this "no event" event?

What is the purpose of this "no event" event?

5:06 pm

Sean Nash

What is the purpose of this "no event" event?

What is the purpose of this "no event" event?

5:04 pm

Sean Nash

No stop property for a high priority alarm? PRS 754 says dialysate temperature alarms are low priority. Temp too low = rank 902. Temp too high = rank 901.

No stop property for a high priority alarm?
PRS 754 says dialysate temperature alarms are low priority. Temp too low = rank 902. Temp too high = rank 901.

4:54 pm

Sean Nash

Why no stop?

Why no stop?

4:53 pm

Sean Nash

Why no stop?

Why no stop?

4:52 pm

Sean Nash

For DG faults, let's be consistent. DG fault = TRUE Clear Immediate = TRUE (alarm condition moot because DG going to fault mode) Stops = TRUE (HD pauses treatment for alarm) No Clear = FALSE (so HD...

For DG faults, let's be consistent.
DG fault = TRUE
Clear Immediate = TRUE (alarm condition moot because DG going to fault mode)
Stops = TRUE (HD pauses treatment for alarm)
No Clear = FALSE (so HD can clear alarm when user selects option)
No Resume = TRUE (cannot resume treatment w/o functioning DG)
No Rinseback = FALSE (no reason to prevent patient getting their blood back just because DG failed)
No End Treatment = FALSE (should try to end treatment as normally as possible w/o DG - won't be able to drain reservoirs though)
No Blood Recirc = FALSE (why not recirc blood?)
No Dialysate Recirc = TRUE (may not be possible depending on what's wrong w/ DG)
Clear Only = FALSE

4:45 pm

Sean Nash

Faults (HD and DG) should probably be consistent on clear immediate concept. I think faults should be TRUE on clear immediate (going to fault mode anyway, so alarm condition isn't relevant after th...

Faults (HD and DG) should probably be consistent on clear immediate concept. I think faults should be TRUE on clear immediate (going to fault mode anyway, so alarm condition isn't relevant after that).

4:44 pm

Sean Nash

No stop property for a high priority alarm?

No stop property for a high priority alarm?

9:42 am

Dara Navaei

It seems correct to me.

It seems correct to me.

9:40 am

Dara Navaei

No this line is a temporary line until the pump control is fixed so the 100 mL/min can be achieved.

No this line is a temporary line until the pump control is fixed so the 100 mL/min can be achieved.

9:39 am

Dara Navaei

It is a const because we want it to be calculated upon compilation and be kept in memory. #define does the calculations every time it is called.

It is a const because we want it to be calculated upon compilation and be kept in memory. #define does the calculations every time it is called.

9:37 am

Dara Navaei

Both cannot be and are not defined at the same time.

Both cannot be and are not defined at the same time.

9:36 am

Dara Navaei

It is up to date.

It is up to date.

9:35 am

Dara Navaei

It is up to date.

It is up to date.

9:33 am

Dara Navaei

Done.

Done.

9:32 am

Dara Navaei

Done.

Done.