hdfirmware / firmware / App / Services

SystemCommMessages.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 Oct 2024
4:37 pm

Dara Navaei

Merge branch 'DEN-17093-blood-leak-zeroing-in-treatment' into develop

Options
    • -0
    • +3
    ./SystemCommMessages.h
  2. … 2 more files in changeset.
4:25 pm

Dara Navaei

DEN-17093 added code to override the blood leak zeroing interval

Options
    • -0
    • +3
    ./SystemCommMessages.h
  2. … 4 more files in changeset.
10:49 am

Dara Navaei

Merge branch 'DEN-17093-blood-leak-zeroing-in-treatment' into develop

Options
    • -0
    • +3
    ./SystemCommMessages.h
  2. … 2 more files in changeset.
10:07 am

Dara Navaei

DEN-17093 added a command to override the blood leak intensity moving average

Options
    • -0
    • +3
    ./SystemCommMessages.h
  2. … 4 more files in changeset.
Wednesday 23 Oct 2024
4:56 pm

Dara Navaei

Merge branch 'DEN-17093-blood-leak-zeroing-in-treatment' into develop

Options
    • -0
    • +3
    ./SystemCommMessages.h
  2. … 2 more files in changeset.
1:16 pm

Dara Navaei

DEN-17093 added a command to override the blood leak embedded mode info commands

Options
    • -0
    • +3
    ./SystemCommMessages.h
  2. … 4 more files in changeset.
Tuesday 22 Oct 2024
5:17 pm

Dara Navaei

I changed it to 4 seconds.

I changed it to 4 seconds.

4:59 pm

Dara Navaei

The state machine that is in charge of receiving the response back from the sensor has a timeout and sets the command response as ready.

The state machine that is in charge of receiving the response back from the sensor has a timeout and sets the command response as ready.

1:26 pm

Dara Navaei

Done

Done

1:15 pm

Sean Nash

So now it's enough if 1 or 2 samples in the drift range is enough to re-zero? Still seems too brief to me.

So now it's enough if 1 or 2 samples in the drift range is enough to re-zero? Still seems too brief to me.

1:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:13 pm

Sean Nash

This call to signal pressure stabilization should probably be moved into the request zero function.

This call to signal pressure stabilization should probably be moved into the request zero function.

1:05 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:51 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:50 pm

Sean Nash

Do we need a else if timeout check here? Can we get stuck waiting for response indefinitely?

Do we need a else if timeout check here? Can we get stuck waiting for response indefinitely?

12:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:30 am

Dara Navaei

Removed the static pointer.

Removed the static pointer.

10:29 am

Dara Navaei

Removed the state.

Removed the state.

9:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:08 am

Dara Navaei

This code has been removed, please check the handler functions. Also, ternary is a one-liner so sometimes it reduces the lines of code.

This code has been removed, please check the handler functions. Also, ternary is a one-liner so sometimes it reduces the lines of code.

9:05 am

Sean Nash

I'm not seeing that. And why isn't the exec returning a state that you assign to result?

I'm not seeing that. And why isn't the exec returning a state that you assign to result?

9:03 am

Sean Nash

Why are you treating bloodLeakZeroingStatus as a pointer here?

Why are you treating bloodLeakZeroingStatus as a pointer here?

9:00 am

Sean Nash

Not clear to me that this is any better than bypassing the dialyzer in previous state and is likely worse. The way you have it now, the dialysate being pushed by DPi is going to run into a stopped ...

Not clear to me that this is any better than bypassing the dialyzer in previous state and is likely worse. The way you have it now, the dialysate being pushed by DPi is going to run into a stopped DPo and cause a big pressure spike and push dialysate into blood side.

8:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:47 am

Sean Nash

That doesn't answer my question.

That doesn't answer my question.

8:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 21 Oct 2024
5:42 pm

Dara Navaei

Just pushed.

Just pushed.