hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 May 2023
11:54 am

Sean Nash

Merge staging to DEN-15250.

Options
    • -1
    • +3
    ./SystemCommMessages.c
9:20 am

jtaylor  (deleted user)

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

Tuesday 23 May 2023
11:20 am

Sean Nash

DEN-13865: More fixes to alarm re-trigger prevention logic.

Options
    • -2
    • +3
    ./AlarmMgmt.c
11:09 am

Sean Nash

DEN-13865: fix re-trigger block logic.

Options
    • -20
    • +23
    ./AlarmMgmt.c
10:57 am

Sean Nash

DEN-13865: Handle no re-trigger action or end-tx only alarms during rinseback/recirc states of treatment mode.

Options
    • -3
    • +26
    ./AlarmMgmt.c
    • -0
    • +1
    ./AlarmMgmt.h
  3. … 1 more file in changeset.
9:42 am

Sean Nash

DEN-13865: Implemented alarm system feature to prevent alarm re-trigger per new properties. Addressed DEN-15295.

Options
    • -9
    • +32
    ./AlarmMgmt.c
    • -0
    • +1
    ./AlarmMgmt.h
  3. … 2 more files in changeset.
8:36 am

Sean Nash

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

8:35 am

Sean Nash

Do we need the alarm active checks? Isn't power loss check sufficient?

Do we need the alarm active checks? Isn't power loss check sufficient?

12:02 am

Dara Navaei

HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
Monday 22 May 2023
11:16 pm

Sean Nash

Merge branch 'DEN-15250-pre-treatment-does-not-end-successfully' into develop

Options
    • -7
    • +7
    ./SystemCommMessages.c
11:11 pm

Sean Nash

DEN-15250: cosmetic and coding standard changes.

Options
    • -7
    • +7
    ./SystemCommMessages.c
  2. … 2 more files in changeset.
1:40 pm

Michael Garthwaite

11:59 am

jtaylor  (deleted user)

The root cause is that abnormal AC power loss on the HD causes abnormal operating conditions and spurious errors. The valves return to position after the alarm is cleared, not when AC returns. The ...

The root cause is that abnormal AC power loss on the HD causes abnormal operating conditions and spurious errors. The valves return to position after the alarm is cleared, not when AC returns. The timer gives a ten-second window following removing the power fail signal and the alarm condition, where the alarm block is active. The original block used the alarms alone, we changed to the CPLD power loss detection - which returns with the return of AC. Clearing the alarms late means removing the block before the valves return to normal operation.

I think there are two approaches. We already have distributed failsafe that is entered on power fail, which we recover from after the alarm is cleared.
1. Create a pervasive state that affects every operating mode, allowing transitions to "safe" states during alarms, then back to the original operating state. The safe state would not register errors until after the transition back to normal operation.
2. Block errors until both AC is returned and the alarm is cleared when normal operation is restored.

The second approach is much simpler and addresses the root problem: odd control configurations resulting from having alarms with conflicting controls. In this case, the secondary alarms are spurious since they result from the valves dropping into a safe position, for instance, on the loss of AC. We also have a handful of other errors that occur under these conditions, fan speed, for instance, as well as valve positions,

11:57 am

jtaylor  (deleted user)

Added alarm 62 detection disable as suggested.

Added alarm 62 detection disable as suggested.

9:44 am

Sean Nash

Fixed merge conflict.

Options
    • -1
    • +3
    ./SystemCommMessages.c
    • -1
    • +3
    ./SystemCommMessages.h
  3. … 2 more files in changeset.
9:42 am

Sean Nash

Fixed merge conflict.

Options
    • -1
    • +1
    ./SystemCommMessages.c
8:38 am

Sean Nash

DEN-15250: End tx should go to post-tx from pre-tx unless haven't finished water sample state. Require ack on confirmation msgs.

Options
    • -1
    • +1
    ./SystemCommMessages.c
  2. … 1 more file in changeset.
Saturday 20 May 2023
6:04 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./SystemComm.c
    • -1
    • +1
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h
  4. … 2 more files in changeset.
6:03 pm

Dara Navaei

6:02 pm

Sean Nash

4:48 pm

Dara Navaei

DEN-15375 addresed the release fixes

Options
    • -0
    • +2
    ./SystemComm.c
    • -0
    • +2
    ./SystemCommMessages.c
    • -0
    • +2
    ./SystemCommMessages.h
4:46 pm

Dara Navaei

HD-DEN-15375_FW Dialysate Heating Fixes
HD-DEN-15375_FW Dialysate Heating Fixes
Friday 19 May 2023
10:01 am

Dara Navaei

HD-DEN-15250_Pre Treatment Does Not End Successfully
HD-DEN-15250_Pre Treatment Does Not End Successfully
9:59 am

Sean Nash

This doesn't seem like a fix to root cause - may not work if user clears alarm quickly. Suggest looking at valve driver where alarm 62 is detected/triggered and maybe zeroing positionOutOfRangeCoun...

This doesn't seem like a fix to root cause - may not work if user clears alarm quickly.
Suggest looking at valve driver where alarm 62 is detected/triggered and maybe zeroing positionOutOfRangeCounter (reset 1 sec persistence) if AC power is out. That way, when AC is restored, valves will have a whole second to get where they're supposed to be before alarm is triggered.

8:55 am

Sean Nash

8:50 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./AlarmMgmt.c
8:42 am

Dara Navaei , jtaylor  (deleted user) and Michael Garthwaite

Thursday 18 May 2023
4:07 pm

Sean Nash

DEN-15060-2: Another fix to alarm silence functionality.

Options
    • -1
    • +1
    ./AlarmMgmt.c
12:02 pm

Dara Navaei

HD-DEN-15060_2 Nfr Alarms Lower Priority Alarm DE Silence Higher Priority Alarm Audio
HD-DEN-15060_2 Nfr Alarms Lower Priority Alarm DE Silence Higher Priority Alarm Audio
10:50 am

Sean Nash

DEN-15060-2: Fixed issue with alarm silence getting aborted by a lesser ranked alarm.

Options
    • -1
    • +1
    ./AlarmMgmt.c