Tasks

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14001: Addressed code review comments.

  1. … 1 more file in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove this blank line.

Remove this blank line.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Why can't we rename them ourselves? Let's just do it now.

Why can't we rename them ourselves? Let's just do it now.

I don't understand. It's used by nv data but it's not currently used? This enum is supposed to an enum of events that can be sent to UI for logging. Why would we want to log a non-event?

I don't understand. It's used by nv data but it's not currently used? This enum is supposed to an enum of events that can be sent to UI for logging. Why would we want to log a non-event?

This looked better before. Why change?

This looked better before. Why change?

DEN-13834 addressed the code review comments

  1. … 4 more files in changeset.
Done. The ranks will be redefined.

Done. The ranks will be redefined.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

This event is used for NV data management events. HD_EVENT_NO_EVENT is not currently in use.

This event is used for NV data management events. HD_EVENT_NO_EVENT is not currently in use.

Done.

Done.

I am waiting for HDD to be updated to reserved so I can rename them.

I am waiting for HDD to be updated to reserved so I can rename them.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.