Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
No. Removed.

No. Removed.

updated.

updated.

Added index variable and removed duplication of code.

Added index variable and removed duplication of code.

No. Removed.

No. Removed.

Update

Update

Updated

Updated

Per conversation with Sean: It is a DG Fault generated that the HD is identifying.

Per conversation with Sean: It is a DG Fault generated that the HD is identifying.

Leave as is per conversation w Sean. Reported by HD, but actually a DG generated problem.

Leave as is per conversation w Sean. Reported by HD, but actually a DG generated problem.

General comment: Should floating point values be of the format N.NF? What is the coding standard? My experience has been that it's best to always specify the "F".

General comment: Should floating point values be of the format N.NF? What is the coding standard? My experience has been that it's best to always specify the "F".

This has the rank of a fault and I think it should be an HD fault - so set the T/F properties same as the alarm above (FPGA clock speed check).

This has the rank of a fault and I think it should be an HD fault - so set the T/F properties same as the alarm above (FPGA clock speed check).

Maybe change param name to final (i.e. final or start).

Maybe change param name to final (i.e. final or start).

I think we can handle both reservoirs with same code (no need for else). Probably just need to add a macro somewhere that converts a reservoir ID and primary/backup selection into a loadcell ID.

I think we can handle both reservoirs with same code (no need for else). Probably just need to add a macro somewhere that converts a reservoir ID and primary/backup selection into a loadcell ID.

I think this whole condition should be removed. If we are taking baseline reading for a reservoir, it is not time to do the drift check yet. Just need to save the readings here.

I think this whole condition should be removed. If we are taking baseline reading for a reservoir, it is not time to do the drift check yet. Just need to save the readings here.

Remove extra blank line.

Remove extra blank line.

Remove blank line.

Remove blank line.

I think this alarm should be an HD fault for now (no recovery).

I think this alarm should be an HD fault for now (no recovery).

Do an explicit condition here. i.e. if ( TRUE == reservoirFull )

Do an explicit condition here. i.e. if ( TRUE == reservoirFull )

It's not so much empty and full - neither is empty - it's more like start and final weights. Consider renaming these. Also, consider moving these declarations to top of module. Nothing wrong with t...

It's not so much empty and full - neither is empty - it's more like start and final weights. Consider renaming these.
Also, consider moving these declarations to top of module. Nothing wrong with them being here, but the style for this code base has been to declare everything at top of module.

Use FALSE, not false.

Use FALSE, not false.

Use TRUE (not true).

Use TRUE (not true).

Is fabs() appropriate here?

Is fabs() appropriate here?

Is fabs() appropriate here?

Is fabs() appropriate here?

This #define should be at the top of the file.

This #define should be at the top of the file.

HD-DEN-12847_SW Dev Sprint 71 Darren
HD-DEN-12847_SW Dev Sprint 71 Darren
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.